Page MenuHomePhabricator

Video.js should support Score integration
Closed, ResolvedPublic

Description

Test integration of videoJS with the Score integration.

@brion

In videojs mode i see no controls

After verification of fix for T135491: Score/TMH PHP fatal on page view in master

Event Timeline

TheDJ created this task.May 17 2016, 3:48 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 17 2016, 3:48 PM
TheDJ moved this task from Backlog to Player on the TimedMediaHandler board.
brion added a comment.May 17 2016, 4:01 PM

videojs mode is interpreting the disablecontrols var as a boolean:

			if ( $this->disablecontrols ) {
				$mediaAttr[ 'controls' ] = false;
			}

but Score is setting a string with particular options, presumably mwembed-specific:

'disablecontrols' => 'options,timedText',

Change 289308 had a related patch set uploaded (by TheDJ):
Fix the disablecontrols option for videojs

https://gerrit.wikimedia.org/r/289308

TheDJ moved this task from Player to Doing on the TimedMediaHandler board.May 17 2016, 8:48 PM

Change 289308 merged by jenkins-bot:
Fix the disablecontrols option for videojs

https://gerrit.wikimedia.org/r/289308

TheDJ closed this task as Resolved.May 18 2016, 8:13 PM
TheDJ triaged this task as Low priority.
TheDJ moved this task from Doing to Done on the TimedMediaHandler board.
TheDJ removed a project: Patch-For-Review.