Page MenuHomePhabricator

Deprecate disablecontrols option of TMH
Open, Needs TriagePublic

Description

TMH file transclusion currently has an option to hide 3 specific controls (The menu, the subtitles menu and the fullscreen button). This seems like an over engineered solution that we don't really need. Instead we should use classes and CSS styling to achieve the same effect.

Details

Related Gerrit Patches:
mediawiki/extensions/Score : masterUse styles to hide player controls
mediawiki/extensions/TimedMediaHandler : masterAllow mwEmbed to pick up classes from media element

Event Timeline

TheDJ created this task.May 17 2016, 6:33 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 17 2016, 6:33 PM

Change 289323 had a related patch set uploaded (by TheDJ):
[WIP] Use styles to hide player controls

https://gerrit.wikimedia.org/r/289323

Change 289573 had a related patch set uploaded (by TheDJ):
Allow mwEmbed to pick up classes from media element

https://gerrit.wikimedia.org/r/289573

Change 289573 merged by jenkins-bot:
Allow mwEmbed to pick up classes from media element

https://gerrit.wikimedia.org/r/289573

YaganZ added a subscriber: YaganZ.Jul 1 2016, 9:33 PM

Parsoid will surface these bogus options through MediaWiki-extensions-Linter for editors to cleanup.

See https://gerrit.wikimedia.org/r/#/c/335956/19/tests/mocha/linter.js

Change 289323 abandoned by TheDJ:
Use styles to hide player controls

https://gerrit.wikimedia.org/r/289323