Page MenuHomePhabricator

Edit icon shows on Special:MobileCite Page when wgMFAllowNonJavaScriptEditing is true
Closed, ResolvedPublic

Description

Visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileCite/333807 and you'll see the edit page action
This code should not be being loading nor should it be running on a special page.

Event Timeline

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 17 2016, 6:58 PM
Jdlrobson renamed this task from Edit icon shows on Special:MobileCite Page to Edit icon shows on Special:MobileCite Page when wgMFAllowNonJavaScriptEditing is true.May 17 2016, 11:34 PM

Change 289336 had a related patch set uploaded (by Jdlrobson):
Don't load initialision edit or watch code on special pages

https://gerrit.wikimedia.org/r/289336

Change 289336 merged by jenkins-bot:
Don't load initialision edit or watch code on special pages

https://gerrit.wikimedia.org/r/289336

Apparently this didn't quite get fixed. JavaScript doesn't load but edit icon is still there. We'll either need to hide it in CSS (easy) or scrub it from output (not sure if edit icons should be appearing in output anyway)

Jdlrobson closed this task as Resolved.Nov 23 2016, 5:56 PM
Jdlrobson claimed this task.

Icons are no longer showing.