Edit icon shows on Special:MobileCite Page when wgMFAllowNonJavaScriptEditing is true
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	May 17 2016, 6:58 PM

Description

Visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileCite/333807 and you'll see the edit page action
This code should not be being loading nor should it be running on a special page.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Don't load initialision edit or watch code on special pages	mediawiki/extensions/MobileFrontend	master	+10 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdforrester-WMF	T125174 [EPIC] Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend
		Resolved		Jdlrobson	T135542 Edit icon shows on Special:MobileCite Page when wgMFAllowNonJavaScriptEditing is true

Event Timeline

Jdlrobson created this task.May 17 2016, 6:58 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 17 2016, 6:58 PM

Jdlrobson mentioned this in T125897: Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users.May 17 2016, 6:58 PM

Jdlrobson added a parent task: T125897: Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users.

Jdlrobson added a project: Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one.May 17 2016, 9:26 PM

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.

Jdlrobson added a project: Unplanned-Sprint-Work.

Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.May 17 2016, 11:21 PM

Jdlrobson renamed this task from Edit icon shows on Special:MobileCite Page to Edit icon shows on Special:MobileCite Page when wgMFAllowNonJavaScriptEditing is true.May 17 2016, 11:34 PM

Change 289336 had a related patch set uploaded (by Jdlrobson):
Don't load initialision edit or watch code on special pages

https://gerrit.wikimedia.org/r/289336

gerritbot added a project: Patch-For-Review.May 17 2016, 11:39 PM

Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.May 17 2016, 11:39 PM

Change 289336 merged by jenkins-bot:
Don't load initialision edit or watch code on special pages

https://gerrit.wikimedia.org/r/289336

Apparently this didn't quite get fixed. JavaScript doesn't load but edit icon is still there. We'll either need to hide it in CSS (easy) or scrub it from output (not sure if edit icons should be appearing in output anyway)

Jdlrobson removed a project: Patch-For-Review.May 18 2016, 2:29 PM

Jdlrobson moved this task from Ready for Signoff to To Do on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.

Jdlrobson removed a parent task: T125897: Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users.

Jdlrobson triaged this task as Medium priority.May 19 2016, 5:12 PM

Jdlrobson removed projects: Unplanned-Sprint-Work, Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one.

Jdlrobson added a project: Web-Team-Backlog-Archived.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-24_(1.28.0-wmf.3)).May 24 2016, 11:34 AM

• jhobs moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.May 25 2016, 9:32 PM

Jdlrobson added a parent task: T125174: [EPIC] Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend.May 25 2016, 9:32 PM