Given http://caniuse.com/svg it looks like SVG is supported by all our grade A browsers (with exception of Android 2.x but given we only support this on mobile and hovercards only works on desktop this may be acceptable).
We should thus remove any fallback SVG rendering.
Description
Description
Details
Details
Related Changes in Gerrit:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Dereckson | T68374 Enable Hovercards on se.wikimedia.org (Swedish chapter wiki) | |||
| Resolved | Jdlrobson | T70860 [GOAL] Graduate Page Previews feature (Popups extension) out of Beta Feature | |||
| Resolved | phuedx | T135554 Drop SVG fallback support for Hovercards |
Event Timeline
Comment Actions
Change 289088 had a related patch set uploaded (by Jdlrobson):
Drop support for non-SVG browsers
Comment Actions
^ From the commit message:
Note: untested! Better commit message to follow!
I'll continue reviewing and testing the change.
Comment Actions
The following are screenshots from IE9, IE10, and IE11 on Windows 7 (via VirtualBox) respectively:
SVG clipping and masking is supported in IE9+ https://msdn.microsoft.com/library/bg124134(v=vs.85).aspx?tduid=(746b80363c478a6c952b9eff784481d2)(256380)(2459594)(TnL5HPStwNw-c0eADJB13fx.XNq5keTJNA)() so it looks as if mw.popups.render.renderers.article#createSvgImageThumbnail or a client of the method is broken. N.B. that this also affects master with mw.popups.supportsSVG set to true.
Edit
This behaviour was uncovered by 69fff17. If I'd tested it in IE9 and IE10/11 at the time, then I'd probably have caught it.
Comment Actions
SVG clipping and masking is supported in IE9+ https://msdn.microsoft.com/library/bg124134(v=vs.85).aspx?tduid=(746b80363c478a6c952b9eff784481d2)(256380)(2459594)(TnL5HPStwNw-c0eADJB13fx.XNq5keTJNA)() so it looks as if mw.popups.render.renderers.article#createSvgImageThumbnail or a client of the method is broken.
Ah! We're using CSS clipping (barely supported) with a clip path defined in an SVG element.
mw.popups.createSVGMask doesn't work in IE9+. div#mwe-popups-svg is inserted into the DOM but has no children, i.e. no clip-paths are being defined.
Comment Actions
Change 292131 had a related patch set uploaded (by Phuedx):
[WIP] Make SVG image clipping cross-browser
Comment Actions
^ I tagged 292131: WIP Make SVG image clipping cross-browser with this task for posterity.
Comment Actions
https://gerrit.wikimedia.org/r/#/c/292131/ seems important to me, moving back to code review.
Comment Actions
Change 292131 abandoned by Phuedx:
Make SVG image clipping cross-browser
Reason:
I was overzealous in my bug hunt.
Comment Actions
After creating some better test pages this morning, it seems as if this work has uncovered a distinct bug. I'll report the bug shortly.
Comment Actions
During my bug hunt I verified that SVGs render and are clipped in IE9, 10, and 11 on Windows 7 (via VirtualBox). I'm happy to sign this off.