Page MenuHomePhabricator
Create Task
Maniphest T135576

sleep() calls in PHPSessionHandlerTest::testSessionHandling() slow down test runs
Closed, ResolvedPublic
Actions

Description

PHPSessionHandlerTest::testSessionHandling() sleeps for three seconds each time it is invoked. It gets invoked three times (once for each dataset provided by its dataProvider method), for a total of 9 seconds, making it the slowest test in core by a comfortable margin. There ought to be a way to simulate the passage of time using mocks and test doubles.

Details

SubjectRepoBranchLines +/-
Remove a test case from PHPSessionHandlerTest::testSessionHandling()mediawiki/coreREL1_27+0 -8
Remove a test case from PHPSessionHandlerTest::testSessionHandling()mediawiki/coremaster+0 -8
Customize query in gerrit

Related Objects

Event Timeline

ori created this task.May 18 2016, 12:55 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 18 2016, 12:55 AM
gerritbot subscribed.May 18 2016, 8:40 AM

Change 289360 had a related patch set uploaded (by Ori.livneh):
PHPSessionHandlerTest: don't sleep() to test PHP

https://gerrit.wikimedia.org/r/289360

gerritbot added a project: Patch-For-Review.May 18 2016, 8:40 AM
hashar subscribed.May 18 2016, 10:54 AM

The sleep( 3 ) has been introduced by rMW25dbd91513f1: Clean up after Ie161e0f

gerritbot added a comment.Jun 1 2016, 1:21 PM

Change 289360 merged by jenkins-bot:
Remove a test case from PHPSessionHandlerTest::testSessionHandling()

https://gerrit.wikimedia.org/r/289360

gerritbot added a comment.Jun 1 2016, 1:34 PM

Change 292130 had a related patch set uploaded (by Hashar):
Remove a test case from PHPSessionHandlerTest::testSessionHandling()

https://gerrit.wikimedia.org/r/292130

gerritbot added a comment.Jun 1 2016, 1:46 PM

Change 292130 merged by jenkins-bot:
Remove a test case from PHPSessionHandlerTest::testSessionHandling()

https://gerrit.wikimedia.org/r/292130

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)), MW-1.27-release-notes.Jun 1 2016, 2:00 PM
hashar closed this task as Resolved.Aug 25 2016, 11:03 AM
hashar assigned this task to ori.

Fixed month ago via ori patch

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL