[16:43:41] <MaxSem> legoktm, argh https://github.com/wikimedia/mediawiki-debian/blob/master/patches/debian_specific_config.patch [16:44:11] <MaxSem> did you know that we have means to do that without patches? [16:44:28] <legoktm> I didn't write that patch :P [16:45:18] <legoktm> MaxSem: how would you do that though? [16:46:09] <MaxSem> https://github.com/wikimedia/mediawiki/blob/master/mw-config/overrides.php [16:46:36] <MaxSem> guess it can be modified to work more like settings.d [16:48:47] <legoktm> so we patch overrides.php instead of LocalSettingsGenerator.php? [16:49:00] <MaxSem> yep [16:49:39] <MaxSem> or, just make it load overrides from a directory so that package could just drop its overrides there, legoktm
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Change the way installer overrides work | mediawiki/core | REL1_27 | +53 -32 | |
Change the way installer overrides work | mediawiki/core | master | +53 -32 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 289581 had a related patch set uploaded (by MaxSem):
Change the way installer overrides work
Comment Actions
Change 293524 had a related patch set uploaded (by Legoktm):
Change the way installer overrides work
Comment Actions
I removed it as a 1.27 blocker, I'm still working on fixing the Debian packaging part :)