Upstream: https://we.phorge.it/T16039
When going through the list of files I shared it would be very convenient to have a visual representation of those in addition to their name, especially for mockups and other image based assets.
Description
Description
Related Objects
Related Objects
- Mentioned In
- T135327: Decide Phabricator improvements to be funded by WMF Technical Collaboration
- Mentioned Here
- P74484 T135729
Event Timeline
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 19 2016, 1:18 PM2016-05-19 13:18:07 (UTC+0)
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 19 2016, 1:30 PM2016-05-19 13:30:07 (UTC+0)
Aklapper changed the subtype of this task from "Task" to "Feature Request".Oct 28 2023, 2:10 PM2023-10-28 14:10:32 (UTC+0) ·
Comment Actions
First step would likely make File Transforms by default also create a "Thumbgrid (100px)"/TRANSFORM_THUMBGRID.
Currently the code only creates a "Preview (220px)"/TRANSFORM_PREVIEW by default for bitmap image files).
Aklapper raised the priority of this task from Lowest to Low.Edited · Mar 23 2025, 1:09 PM2025-03-23 13:09:13 (UTC+0)
Comment ActionsProof of concept patch to render 48x48px thumbnails for image files:
| 1 | diff --git a/src/applications/files/query/PhabricatorFileSearchEngine.php b/src/applications/files/query/PhabricatorFileSearchEngine.php |
|---|---|
| 2 | index c2d36acfd6..c9d7af20af 100644 |
| 3 | --- a/src/applications/files/query/PhabricatorFileSearchEngine.php |
| 4 | +++ b/src/applications/files/query/PhabricatorFileSearchEngine.php |
| 5 | @@ -143,6 +143,10 @@ final class PhabricatorFileSearchEngine |
| 6 | $list_view = id(new PHUIObjectItemListView()) |
| 7 | ->setUser($viewer); |
| 8 | |
| 9 | + if ($query->getQueryKey() === 'authored') { |
| 10 | + $authored_view = true; |
| 11 | + } |
| 12 | + |
| 13 | foreach ($files as $file) { |
| 14 | $id = $file->getID(); |
| 15 | $phid = $file->getPHID(); |
| 16 | @@ -158,12 +162,30 @@ final class PhabricatorFileSearchEngine |
| 17 | $uploaded = pht('Uploaded on %s', $date_created); |
| 18 | } |
| 19 | |
| 20 | + // render image thumbnails when looking at your authored files |
| 21 | + $thumbnail = null; |
| 22 | + if (isset($authored_view)) { |
| 23 | + if ($file->isViewableImage()) { |
| 24 | + $xform = PhabricatorFileTransform::getTransformByKey( |
| 25 | + PhabricatorFileThumbnailTransform::TRANSFORM_THUMBGRID); |
| 26 | + $attributes = array( |
| 27 | + 'width' => 48, |
| 28 | + 'height' => 48, |
| 29 | + 'src' => $file->getURIForTransform($xform), |
| 30 | + ); |
| 31 | + $thumbnail = phutil_tag('img', $attributes); |
| 32 | + } else { |
| 33 | + $thumbnail = phutil_tag('span'); |
| 34 | + } |
| 35 | + } |
| 36 | + |
| 37 | $item = id(new PHUIObjectItemView()) |
| 38 | ->setObject($file) |
| 39 | ->setObjectName("F{$id}") |
| 40 | ->setHeader($name) |
| 41 | ->setHref($file_uri) |
| 42 | ->addAttribute($uploaded) |
| 43 | + ->setSideColumn($thumbnail) |
| 44 | ->addIcon('none', phutil_format_bytes($file->getByteSize())); |
| 45 | |
| 46 | $ttl = $file->getTTL(); |
| 47 | diff --git a/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css b/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css |
| 48 | index 0ae87aafcf..9b8e801aa5 100644 |
| 49 | --- a/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css |
| 50 | +++ b/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css |
| 51 | @@ -190,6 +190,10 @@ ul.phui-oi-list-view { |
| 52 | width: 200px; |
| 53 | } |
| 54 | |
| 55 | +.phui-oi-col2.phui-oi-side-column > img { |
| 56 | + display: inline-block; |
| 57 | +} |
| 58 | + |
| 59 | .device-phone .phui-oi-col1, |
| 60 | .device-phone .phui-oi-col2 { |
| 61 | display: block; |
A bit expensive thus only rendering for your own authored files.
Plus turns everything into a square but I don't mind.
Plus re-uses some hardcoded too-wide column width but I don't mind.
Aklapper updated the task description. (Show Details)Apr 21 2025, 9:55 AM2025-04-21 09:55:57 (UTC+0)
Aklapper moved this task from Reported Upstream to Patch proposed upstream on the Upstream board.May 17 2025, 1:09 PM2025-05-17 13:09:13 (UTC+0)