Page MenuHomePhabricator
Create Task
Maniphest T135743

Can't load In Progress or Published translation list
Closed, ResolvedPublic
Actions

Description

Console:

Uncaught TypeError: str.replace is not a function

Further, Language selector on In progress and Published tab is not working with following,

Uncaught TypeError: Cannot read property 'hide' of undefined

Details

SubjectRepoBranchLines +/-
Avoid passing integers to mw.RegExp.escapemediawiki/corewmf/1.28.0-wmf.4+1 -1
Avoid passing integers to mw.RegExp.escapemediawiki/corewmf/1.28.0-wmf.3+1 -1
Avoid passing integers to mw.RegExp.escapemediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

KartikMistry created this task.May 19 2016, 2:55 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 19 2016, 2:55 PM
KartikMistry added a comment.May 19 2016, 2:58 PM

This seems affected wmf1 branch as of now.

KartikMistry added a comment.May 19 2016, 3:05 PM

Trace 1:

Uncaught TypeError: str.replace is not a function

mw.RegExp.escape @ mediawiki.RegExp.js?4e552:19
moment.locale.postformat @ moment-locale-overrides.js?12e64:45
extend.humanize @ moment.js?a3c5c:2741
extend.from @ moment.js?a3c5c:2260
extend.fromNow @ moment.js?a3c5c:2264
CXTranslationList.renderTranslations @ ext.cx.translationlist.js?c3e42:258
(anonymous function) @ ext.cx.translationlist.js?c3e42:105
fire @ load.php?debug=true&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=m7F5ikBY:3148
self.fireWith @ load.php?debug=true&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=m7F5ikBY:3260
(anonymous function) @ load.php?debug=true&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=m7F5ikBY:3312
fire @ load.php?debug=true&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=m7F5ikBY:3148
self.fireWith @ load.php?debug=true&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=m7F5ikBY:3260
deferred.(anonymous function) @ load.php?debug=true&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=m7F5ikBY:3350
(anonymous function) @ api.js?10e9f:256fire @ load.php?debug=true&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=m7F5ikBY:3148
self.fireWith @ load.php?debug=true&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=m7F5ikBY:3260
done @ load.php?debug=true&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=m7F5ikBY:9314
callback @ load.php?debug=true&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=m7F5ikBY:9718
Nikerabbit added a subscriber: matmarex.May 19 2016, 3:07 PM

Could be related to interface language. Recent change in this area is https://gerrit.wikimedia.org/r/289132.

KartikMistry added a comment.May 19 2016, 3:14 PM

@Nikerabbit That's the case. Tested cawiki with Gujarati interface and I can reproduce there.

matmarex edited subscribers, added: Catrope; removed: matmarex.May 19 2016, 3:22 PM

If anything, I'd look at that change's predecessor, https://gerrit.wikimedia.org/r/#/c/281198/.

Amire80 triaged this task as High priority.May 19 2016, 4:42 PM

Huh? How frequent is this? Sounds pretty bad.

Amire80 moved this task from Needs Triage to CX9 on the ContentTranslation board.May 19 2016, 4:42 PM
Nikerabbit added a comment.May 19 2016, 4:45 PM

@Amire80 Always for certain interface languages if you have done any translations.

Amire80 added a comment.May 19 2016, 4:49 PM

OK, moving to Upstream. Please correct me if I'm wrong.

Amire80 moved this task from CX9 to Upstream/Other teams on the ContentTranslation board.May 19 2016, 4:49 PM
KartikMistry added a subscriber: • santhosh.May 24 2016, 4:59 AM
KartikMistry added a comment.May 31 2016, 4:10 AM

More users are affected: https://www.mediawiki.org/wiki/Topic:T4lta8pdgpwrs04f and https://gu.wikipedia.org/wiki/%E0%AA%B5%E0%AA%BF%E0%AA%95%E0%AA%BF%E0%AA%AA%E0%AB%80%E0%AA%A1%E0%AA%BF%E0%AA%AF%E0%AA%BE:%E0%AA%9A%E0%AB%8B%E0%AA%A4%E0%AA%B0%E0%AB%8B#.E0.AA.97.E0.AB.81.E0.AA.9C.E0.AA.B0.E0.AA.BE.E0.AA.A4.E0.AB.80_.E0.AA.AD.E0.AA.BE.E0.AA.B7.E0.AA.BE_.E0.AA.AE.E0.AA.BE.E0.AA.9F.E0.AB.87_.E0.AA.AD.E0.AA.BE.E0.AA.B7.E0.AA.BE.E0.AA.82.E0.AA.A4.E0.AA.B0_.E0.AA.B8.E0.AA.BE.E0.AA.A7.E0.AA.A8.E0.AA.AE.E0.AA.BE.E0.AA.82_.E0.AA.AE.E0.AA.B6.E0.AB.80.E0.AA.A8_.E0.AA.AD.E0.AA.BE.E0.AA.B7.E0.AA.BE.E0.AA.82.E0.AA.A4.E0.AA.B0

gerritbot subscribed.May 31 2016, 10:01 AM

Change 291889 had a related patch set uploaded (by Santhosh):
Avoid passing integers to mw.RegExp.escape

https://gerrit.wikimedia.org/r/291889

gerritbot added a project: Patch-For-Review.May 31 2016, 10:01 AM
• santhosh claimed this task.May 31 2016, 10:23 AM
• santhosh added a project: Language-Q4-2016-Sprint 4.Jun 1 2016, 3:43 AM
gerritbot added a comment.Jun 1 2016, 4:36 AM

Change 291889 merged by jenkins-bot:
Avoid passing integers to mw.RegExp.escape

https://gerrit.wikimedia.org/r/291889

• santhosh moved this task from Backlog to QA on the Language-Q4-2016-Sprint 4 board.Jun 1 2016, 4:58 AM
ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)), MW-1.28-release-notes.Jun 1 2016, 5:00 AM
KartikMistry added a comment.Jun 1 2016, 5:14 AM

Works fine in local, Labs (http://cx2.wmflabs.org/index.php/Special:ContentTranslation) and Beta (http://en.wikipedia.beta.wmflabs.org/wiki/Special:ContentTranslation)

gerritbot added a comment.Jun 1 2016, 6:24 AM

Change 292086 had a related patch set uploaded (by KartikMistry):
Avoid passing integers to mw.RegExp.escape

https://gerrit.wikimedia.org/r/292086

gerritbot added a comment.Jun 1 2016, 6:24 AM

Change 292087 had a related patch set uploaded (by KartikMistry):
Avoid passing integers to mw.RegExp.escape

https://gerrit.wikimedia.org/r/292087

gerritbot added a comment.Jun 1 2016, 11:16 AM

Change 292086 abandoned by KartikMistry:
Avoid passing integers to mw.RegExp.escape

Reason:
Backport to wmf4 is good enough, no need to backport to wmf3.

https://gerrit.wikimedia.org/r/292086

gerritbot added a comment.Jun 1 2016, 3:23 PM

Change 292087 merged by jenkins-bot:
Avoid passing integers to mw.RegExp.escape

https://gerrit.wikimedia.org/r/292087

KartikMistry added a comment.Jun 1 2016, 3:35 PM

testwiki seems fine (wmf4).

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-31_(1.28.0-wmf.4)).Jun 1 2016, 4:00 PM
• santhosh moved this task from QA to Done on the Language-Q4-2016-Sprint 4 board.Jun 2 2016, 3:48 AM
matmarex closed this task as Resolved.Jun 2 2016, 10:23 AM
matmarex mentioned this in T136231: Uncaught TypeError: str.replace is not a function.

Thanks for fixing this! It apparently also affected VisualEditor and UploadWizard, but you folks noticed it first ;)

matmarex merged tasks: T136263: Can't open Add Media dialog in VE, T136231: Uncaught TypeError: str.replace is not a function.Jun 2 2016, 10:24 AM
matmarex added a project: MediaWiki-General.
matmarex added subscribers: matmarex, Jdforrester-WMF, Esanders and 3 others.
• Petar.petkovic removed projects: MW-1.28-release (WMF-deploy-2016-05-31_(1.28.0-wmf.4)), Patch-For-Review.May 25 2018, 6:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL