TemplateStyles should support media queries
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Jdlrobson
	May 19 2016, 11:41 PM

Description

My media queries seem to be ignored in http://ts.wmflabs.org/w/index.php/Template:TwoColumnLayout

They are added as global styles rather than @media wrapped styles.
See: http://ts.wmflabs.org/w/index.php/Two_col_layout

Expected: at < 768px the styles do not apply.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/TemplateStyles	master	+1 K -953	Use wikimedia/css-sanitizer, and rewrite the hooking

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		None	T208761 [Epic] Improve PHPUnit coverage in MobileFrontend to 50%
Resolved		• Jdlrobson	T186627 Remove the MobileView API
Declined		None	T173379 Remove mobileview API call for main page
Duplicate		None	T172525 [EPIC] Deprecate MobileView API in MobileFrontend
Resolved		• Jdlrobson	T32405 [EPIC] MobileFrontend extension should stop special-casing main page
Duplicate		None	T138449 Throw warning when edits made to a main page which uses special casing
Duplicate		None	T138622 Help community migrate away from legacy Main page special casing
Declined		None	T125920 [EPIC] Future exciting reading web performance endeavours
Resolved		• Jdlrobson	T131423 FOUC in section "Recently featured" on mobile Main Page
Duplicate		None	T126137 FOUC for styles applied via MediaWiki:Mobile.css due to bottom-loading
Duplicate		None	T130846 Hat-note FOUC on mobile skin
Resolved		None	T51440 MobileFrontend images shown double-sized in Retina desktop, iOS 7 beta
Open		None	T40848 Security: CSS positioning can be used to break out of the content area
Open		None	T37704 Drop support in wikitext for inline styles
Resolved		TheDJ	T151170 Varying layouts for commons mobile main page
Declined		None	T125257 Infoboxes should take the max. available width of the screen
Invalid		None	T135857 Map points aligned to viewport on mobile
Open	Feature	None	T17075 Per book, category and/or template CSS and JavaScript
Invalid		None	T109152 [EPIC] All templates on wiki should work in mobile
Resolved		TheDJ	T94107 {{hat}} and similar templates on Wikipedia are invisible to mobile web view.
Resolved		TheDJ	T118062 In the mobile frontend, in the list produced by Template:Notelist-ua, efn-ua footnotes appear with numeric labels instead of uppercase-alpha. They appear normal in the text, and in the desktop frontend.
Invalid		None	T120238 Wrong display of certain English Wikipedia portal pages in mobile
Resolved		Izno	T127727 navigational sidebar on mobile, should float on wide screens.
Resolved		TheDJ	T128095 Signpost is not readable on mobile devices
Open		None	T117950 Remove the need for `.noprint`
Resolved		• Jdlrobson	T117951 Remove templaters' need for .nomobile and support authoring media queries for templates
Open		ovasileva	T66577 Large tables created by editors are not responsive
Declined		None	T66578 Migrate css rules in hacks.less into templates
Resolved		Tgr	T133410 Deploy TemplateStyles to WMF production
Resolved		Anomie	T135788 TemplateStyles should support media queries
Declined	BUG REPORT	None	T138343 [BUG] Certain Articles can Scroll Left & Right

Event Timeline

• Jdlrobson created this task.May 19 2016, 11:41 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 19 2016, 11:41 PM

Edokter mentioned this in T138622: Help community migrate away from legacy Main page special casing.Jun 29 2016, 7:43 PM

• Jdlrobson added a subtask: T138622: Help community migrate away from legacy Main page special casing.Jun 30 2016, 5:47 PM

Edokter added a subscriber: Edokter.Jun 30 2016, 7:01 PM

@coren was this intentional or is this an oversight? Anything for me to worry about if I submit a patch?

@coren: Could you answer the last question please? ^^

• jhobs renamed this task from Doesn't have proper media query support to TemplateStyles should support media queries.Oct 20 2016, 7:38 PM

• jhobs updated the task description. (Show Details)

Tgr removed subtasks: T133410: Deploy TemplateStyles to WMF production, T138622: Help community migrate away from legacy Main page special casing.Dec 9 2016, 11:56 PM

Tgr added a parent task: T133410: Deploy TemplateStyles to WMF production.

Very simple styles such as @media print do work. @media rules where the component value starts with a ( end up being misinterpreted as rules which can only be followed by a one level deep block. Pretty sure that's not intentional.

JMinor added a subtask: T138343: [BUG] Certain Articles can Scroll Left & Right.Apr 3 2017, 9:49 PM

• NHarateh_WMF reopened subtask T138343: [BUG] Certain Articles can Scroll Left & Right as Open.Apr 3 2017, 10:37 PM

Change 346808 had a related patch set uploaded (by Anomie):
[mediawiki/extensions/TemplateStyles@master] Use wikimedia/css-sanitizer, and rewrite the hooking

https://gerrit.wikimedia.org/r/346808

gerritbot added a project: Patch-For-Review.Apr 6 2017, 6:48 PM

JMinor changed the status of subtask T138343: [BUG] Certain Articles can Scroll Left & Right from Open to Stalled.Apr 20 2017, 6:57 PM

Change 346808 merged by jenkins-bot:
[mediawiki/extensions/TemplateStyles@master] Use wikimedia/css-sanitizer, and rewrite the hooking

https://gerrit.wikimedia.org/r/346808

Anomie closed this task as Resolved.Jun 7 2017, 4:13 PM

Anomie claimed this task.

• ggellerman moved this task from Backlog to Done on the TemplateStyles board.Nov 21 2017, 7:16 PM

Aklapper changed the status of subtask T138343: [BUG] Certain Articles can Scroll Left & Right from Stalled to Open.May 10 2020, 11:12 AM

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 10 2020, 11:12 AM

LGoto closed subtask T138343: [BUG] Certain Articles can Scroll Left & Right as Declined.May 4 2021, 10:11 PM