Stashbot shouldn't subscribe itself to tasks
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Danny_B
	May 19 2016, 11:54 PM

Description

@Stashbot shouldn't subscribe itself to tasks - cf. @gerritbot's actions

Related Objects

Mentioned In: T137508: Bots should not subscribe themselves to tasks
Mentioned Here: T131459: Add default spam prevention tools or settings to wmflabs instances
T115742: Feature request: filter task's bot CCs to the end of the ellipsis

Event Timeline

Danny_B created this task.May 19 2016, 11:54 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 19 2016, 11:54 PM

Stashbot doesn't have the bot flag, so I don't think there is any way to keep it from getting associated automatically with tasks it comments on. Out of random curiosity, what harm does it cause?

I didn't say it causes any harm, though some inconveniences are relevant - T115742: Feature request: filter task's bot CCs to the end of the ellipsis. It's for the sake of consistency as well.

From https://secure.phabricator.com/book/phabricator/article/users/#bot-accounts

The Bot role for an account can not be changed after the account is created. This prevents administrators form changing a normal user into a bot, retrieving their Conduit certificate, and then changing them back (which would allow administrators to gain other users' credentials).

Since there is no way to covert the Stashbot account to a bot account, I'm going to decline this request.

Reopening for a bit until it's verified that the manual doesn't mean only there is no straightforward way via web UI (ie. is it or is it not changeable via direct db access?)

bd808 triaged this task as Low priority.May 20 2016, 2:31 AM

bd808 edited projects, added Tools, Phabricator; removed User-bd808.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 20 2016, 2:31 AM

@mmodell Could you please find out? Thanks.

@Danny_B: stashbot is now marked as a bot. I'm not sure that will prevent it from being subscribed to tasks though.

Thanks. @bd808 mentioned necessity of botflag, so he perhaps knows, what and how to set it...

Peachey88 subscribed.Jun 3 2016, 8:38 AM

Mentioned in SAL [2016-06-03T17:24:31Z] <bd808> Check to see if having bot flag in phab fixes autosubscribe for T135790

It looks to me like setting the bot flag in the Phab db has stopped the autosubscribe action.

Restricted Application added a project: User-bd808. · View Herald TranscriptJun 3 2016, 5:25 PM

bd808 reassigned this task from bd808 to • mmodell.Jun 3 2016, 5:26 PM

bd808 moved this task from To Do to Done on the User-bd808 board.

bd808 moved this task from Done to Archive on the User-bd808 board.Jun 3 2016, 11:01 PM

Thanks to both!

Phabricator seems to have changed the default behavior related to the bot account flag. @gerritbot is now getting subscribed to tasks on comment as well: T131459#2369285