Page MenuHomePhabricator

Stashbot shouldn't misuse {nav} macro for its reports
Closed, DeclinedPublic

Description

Stashbot shouldn't misuse {nav} macro for its reports

Currently:
Mentioned in SAL [2016-05-19T23:33:03Z] <user@machine> Message

{nav icon=file, name=Mentioned in SAL, href=https://tools.wmflabs.org/sal/log/…} [2016-05-19T23:33:03Z] <user@machine> Message

Could be:
Mentioned in SAL [2016-05-19T23:33:03Z] <user@machine> Message

{icon file color=blue} [[ https://tools.wmflabs.org/sal/log/… | Mentioned in SAL ]] [2016-05-19T23:33:03Z] <user@machine> Message

Mentioned in SAL [2016-05-19T23:33:03Z] <user@machine> Message

**!!{icon file} Mentioned in [[ https://tools.wmflabs.org/sal/log/… | SAL ]]!!** `[2016-05-19T23:33:03Z]` <user@machine> Message
Mentioned in SAL [2016-05-19T23:33:03Z] <user@machine> Message
(NOTE) {icon file} Mentioned in SAL [2016-05-19T23:33:03Z] <user@machine> Message

Or we can even create tag for that:
Mentioned in SAL [[ https://tools.wmflabs.org/sal/log/… | [2016-05-19T23:33:03Z] ]] <user@machine> Message

#mentioned-in-sal [[ https://tools.wmflabs.org/sal/log/… | `[2016-05-19T23:33:03Z]` ]] <user@machine> Message

Event Timeline

I don't understand how this particular selection of markup is "misuse". Are you proposing that css styles related to certain built in macros offered by Phabricator have some sort of sacrosanct usage restrictions?

bd808 triaged this task as Lowest priority.May 20 2016, 12:46 AM

The semantic intent of the {nav} markup is actually why I chose it as the stylized link to the https://tools.wmflabs.org/sal/ record that the bot is recording in a task comment. I wanted the comments to stand out in the timeline for a task.