Replace hovercards usage of exsentences with exchars and exintro (like iOS native app)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Given the bugs that sentence detection in textextracts, let's migrate hovercards to use exintro instead of exchars for the summary.

Spike: T135020
Related bugs: T115817

Acceptance criteria

Request 525 characters
Use exintro on the query, otherwise exchars will return unparsed wikitext from followup sections
~~Adjust the currently oversimplified approach of overflow: hidden (which cuts sentences off mid word) to use text-overflow: ellipsis (which has a better tradeoff of ellipsizing things midword).~~
- Moved to T136283 as it is a new feature and it doesn't block test/initial rollout.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Popups	master	+16 -1	Use exchars instead of exsentences for the extract

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Dereckson	T68374 Enable Hovercards on se.wikimedia.org (Swedish chapter wiki)
Resolved	Jdlrobson	T70860 [GOAL] Graduate Page Previews feature (Popups extension) out of Beta Feature
Resolved	Jdlrobson	T132602 [GOAL] Roll Hovercards out on smaller wikipedia project
Resolved	putnik	T115817 Template "lang" badly processed
Duplicate	None	T136283 Add ellipsis to the extract when the text overflows.
Resolved	Jhernandez	T135824 Replace hovercards usage of exsentences with exchars and exintro (like iOS native app)

Event Timeline

Jhernandez created this task.May 20 2016, 10:52 AM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 20 2016, 10:52 AM

Jhernandez moved this task from Incoming to 2016-17 Q2 on the Readers-Web-Backlog board.May 20 2016, 10:53 AM

Jhernandez added a project: Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card.

Jhernandez added a parent task: T132602: [GOAL] Roll Hovercards out on smaller wikipedia project.

Jhernandez mentioned this in T115817: Template "lang" badly processed.May 20 2016, 10:56 AM

Jhernandez added a parent task: T115817: Template "lang" badly processed.

Jhernandez mentioned this in T135825: Replace related pages usage of exsentences with exchars.May 20 2016, 11:05 AM

dr0ptp4kt updated the task description. (Show Details)May 23 2016, 12:10 PM

Jdlrobson renamed this task from Replace hovercards usage of exsentences with exchars to Replace hovercards usage of exsentences with exintro.May 23 2016, 4:31 PM

• jhobs updated the task description. (Show Details)May 23 2016, 4:32 PM

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 23 2016, 4:33 PM

Jdlrobson set the point value for this task to 2.

dr0ptp4kt renamed this task from Replace hovercards usage of exsentences with exintro to Replace hovercards usage of exsentences with exchars and exintro (like iOS native app).May 23 2016, 7:15 PM

dr0ptp4kt moved this task from 2016-17 Q2 to 2015-16 Q4 on the Readers-Web-Backlog board.May 23 2016, 7:36 PM

Jhernandez triaged this task as Medium priority.May 25 2016, 10:33 AM

Jhernandez claimed this task.May 25 2016, 10:51 AM

Jhernandez moved this task from To Do to Doing on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 25 2016, 10:55 AM

Jhernandez created subtask T136283: Add ellipsis to the extract when the text overflows..May 26 2016, 10:40 AM

Jhernandez removed a subtask: T136283: Add ellipsis to the extract when the text overflows..

Jhernandez added a parent task: T136283: Add ellipsis to the extract when the text overflows..

Jhernandez updated the task description. (Show Details)

There is no good reliable way of doing multi line ellipsis only with CSS, and currently hovercards doesn't really do anything about it.

In any case it is a new feature unrelated to the exchars change, so I've splitted it into a followup task for prio, triage and design consideration.

Change 290913 had a related patch set uploaded (by Jhernandez):
Use exchars instead of exsentences for the extract

https://gerrit.wikimedia.org/r/290913

gerritbot added a project: Patch-For-Review.May 26 2016, 10:43 AM

Jhernandez moved this task from Doing to Code Review on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 26 2016, 10:44 AM

The TextExtracts API is appending an ellipsis to the extract which is visible when the extract is short, e.g. the first example from T115817 is dealt with very neatly:

Screen Shot 2016-05-26 at 15.23.15.png (225×337 px, 34 KB)

But the following isn't:

Screen Shot 2016-05-26 at 15.23.48.png (224×326 px, 35 KB)

I note that using CSS ellipsis to deal with this has been moved to T136283 but, given the behaviour of TextExtracts, I'm not convinced that it's a new/distinct feature.

Edit

Thoughts?

phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 26 2016, 2:34 PM

@phuedx before this patch Page-Previews had no ellipsis treatment at all.

I would consider the behavior of TextExtracts of adding an ellipsis even when there is no more content in the page/first section a bug. What do you think?

@phuedx for example, for this page on staging:

http://reading-web-staging.wmflabs.org/w/api.php?action=query&format=json&prop=extracts&formatversion=2&redirects=true&exintro=true&exchars=525&explaintext=true&titles=Test

TextExtracts is adding ... when the full content of the page is already there.

Seems like a bug in exchars IMO.

@phuedx I can remove the '...' if it is there until we get to do the css ellipsis?

In T135824#2330850, @Jhernandez wrote:

Seems like a bug in exchars IMO.

Agreed.

In T135824#2330872, @Jhernandez wrote:

@phuedx I can remove the '...' if it is there until we get to do the css ellipsis?

@phuedx Fixed in last PS.

Jhernandez moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 26 2016, 5:20 PM

Change 290913 merged by jenkins-bot:
Use exchars instead of exsentences for the extract

https://gerrit.wikimedia.org/r/290913

phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 26 2016, 6:27 PM

Jdlrobson removed a project: Patch-For-Review.May 27 2016, 10:01 PM

290913: Use exchars instead of exsentences for the extract has been pulled by the staging server.

I created a test page (and associated pages) to test this change, using the examples from T115817 as well as pre-existing pages.

Since this is a technical change, I'm happy to sign off on it. If anyone objects or we identify a regression, then this task can re-opened.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).May 31 2016, 11:01 PM

Replace hovercards usage of exsentences with exchars and exintro (like iOS native app)Closed, ResolvedPublic2 Estimated Story PointsActions