Page MenuHomePhabricator

[betalabs] Reply text area is present on Resolved topics but replies cannot be saved
Open, Needs TriagePublic

Description

  1. A resolved topic displays 'Reply' area and a user is able to start typing a reply to a resolved topic - no indication that replies cannot be saved.
  2. Only after clicking on 'Reply' button the warning appears: "This topic is resolved, so further activity is not possible."
  3. clicking on Cancel will bring the irrelevant VE popup about 'Continue editing' or 'Discard changes'

Details

Related Gerrit Patches:
mediawiki/extensions/Flow : wmf/1.28.0-wmf.4HACK: Hide reply form for locked topics
mediawiki/extensions/Flow : masterHACK: Hide reply form for locked topics

Event Timeline

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 20 2016, 2:50 PM
Catrope added a subscriber: Ciencia_Al_Poder.
Catrope added a subscriber: Catrope.

According to T136666 the presence of the reply box is in itself a regression.

Change 292204 had a related patch set uploaded (by Mattflaschen):
HACK: Hide reply form for locked topics

https://gerrit.wikimedia.org/r/292204

This is an unintended consequence of rEFLW5f6d32ebc1cb: Disable submit buttons if we know the user can't edit and T108762: Notify users who are editing protected flow content (e.g. F2568115).

The basic idea is to still show the reply box when they can't reply, but warn them when they click inside.

However, I also wanted to remove reply from the actions list, since the main point of that list is for the API to tell you what actions are allowed. (Showing disabled reply forms is a UI choice that ideally should not be reflected in the API.).

Thus, I unconditionally showed the reply form.

However, that didn't take into account the Resolved case (where before it didn't show). To be consistent with this approach, we could either:

  1. Show the reply box for Resolved, but have an explanation when you click inside.
  2. Hide it for Resolved (hopefully a little more elegantly, maybe a showReply flag).
  3. Revisit the whole approach of showing disabled fields with on-click warnings.

Change 292204 merged by jenkins-bot:
HACK: Hide reply form for locked topics

https://gerrit.wikimedia.org/r/292204

Change 292264 had a related patch set uploaded (by Catrope):
HACK: Hide reply form for locked topics

https://gerrit.wikimedia.org/r/292264

Change 292264 merged by jenkins-bot:
HACK: Hide reply form for locked topics

https://gerrit.wikimedia.org/r/292264

Mentioned in SAL [2016-06-02T01:21:24Z] <dereckson@tin> Synchronized php-1.28.0-wmf.4/extensions/Flow/handlebars/: HACK: Hide reply form for locked topics (T135848) (duration: 00m 24s)

This is not fixed for anons, because the patch uses actions.unlock, and anons don't have that right.