Page MenuHomePhabricator

setupSkinUserCss (Hook SkinVectorStyleModules) is no longer called.
Open, Needs TriagePublic

Description

The 1.26.3 patch today made this change:

@@ -3140,9 +3127,6 @@ class OutputPage extends ContextSource {
      * @return string
      */
     function getBottomScripts() {
-        // In case the skin wants to add bottom CSS
-        $this->getSkin()->setupSkinUserCss( $this );
-
         return $this->getScriptsForBottomQueue();
     }

This means the hook SkinVectorStyleModules is no longer called for extensions that rely on it to modify the Vector skin.

Event Timeline

Alexia created this task.May 20 2016, 8:57 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 20 2016, 8:57 PM
matmarex added subscribers: Krinkle, matmarex.

That change was part of https://gerrit.wikimedia.org/r/#/c/273745/ by @Krinkle.

The setupSkinUserCss() method should still be called from OutputPage::buildCssLinks(). Is that not working for you for some reason?

That change was part of https://gerrit.wikimedia.org/r/#/c/273745/ by @Krinkle.
The setupSkinUserCss() method should still be called from OutputPage::buildCssLinks(). Is that not working for you for some reason?

One of the extensions I use plus some others rely on SkinVectorStyleModules to add Javascript into the $styles reference which then gets included through getBottomScripts() in OutputPage.

That doesn't explain anything. I still don't see why the small change in when the hook gets called broke your extension. The function is still called, and it's still called with the same parameters. So is the hook in Vector.

That doesn't explain anything. I still don't see why the small change in when the hook gets called broke your extension. The function is still called, and it's still called with the same parameters. So is the hook in Vector.

The buildCssLinks() function calls getModuleStyles() which adds CSS only. The getScriptsForBottomQueue() function called in getBottomScripts() calls getModuleScripts() which adds the JS.

SamanthaNguyen moved this task from Backlog to Bugs on the Vector board.Jan 5 2017, 4:04 AM