Page MenuHomePhabricator

Use VisualEditorSupportCheck in Flow
Closed, ResolvedPublic1 Story Points

Description

Flow currently duplicates the support check (isSupported) but uses a simplified version of the ES5 check that incorrectly excludes IE9.

We don't know if VE is installed so we have to load VESupportCheck asynchronously.

Event Timeline

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 21 2016, 11:58 AM

Change 289997 had a related patch set uploaded (by Esanders):
Use VisualEditorSupportCheck

https://gerrit.wikimedia.org/r/289997

Change 289997 merged by jenkins-bot:
Use VisualEditorSupportCheck

https://gerrit.wikimedia.org/r/289997

Jdforrester-WMF closed this task as Resolved.May 24 2016, 7:00 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Normal priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Change 295462 had a related patch set uploaded (by Paladox):
Use VisualEditorSupportCheck

https://gerrit.wikimedia.org/r/295462

Change 295463 had a related patch set uploaded (by Paladox):
Use VisualEditorSupportCheck

https://gerrit.wikimedia.org/r/295463

Change 295463 abandoned by Paladox:
Use VisualEditorSupportCheck

https://gerrit.wikimedia.org/r/295463

Change 295466 had a related patch set uploaded (by Paladox):
Use VisualEditorSupportCheck

https://gerrit.wikimedia.org/r/295466

Change 295466 abandoned by Mattflaschen:
Use VisualEditorSupportCheck

Reason:
Doesn't exist in VE on REL1_26.

https://gerrit.wikimedia.org/r/295466

Change 295462 merged by jenkins-bot:
Use VisualEditorSupportCheck

https://gerrit.wikimedia.org/r/295462