Page MenuHomePhabricator
Create Task
Maniphest T135901

Use VisualEditorSupportCheck in Flow
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Flow currently duplicates the support check (isSupported) but uses a simplified version of the ES5 check that incorrectly excludes IE9.

We don't know if VE is installed so we have to load VESupportCheck asynchronously.

Details

SubjectRepoBranchLines +/-
Use VisualEditorSupportCheckmediawiki/extensions/FlowREL1_27+16 -32
Use VisualEditorSupportCheckmediawiki/extensions/FlowREL1_26+19 -28
Use VisualEditorSupportCheckmediawiki/extensions/FlowREL1_26+16 -28
Use VisualEditorSupportCheckmediawiki/extensions/Flowmaster+16 -32
Customize query in gerrit

Event Timeline

Esanders created this task.May 21 2016, 11:58 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 21 2016, 11:58 AM
gerritbot subscribed.May 21 2016, 1:10 PM

Change 289997 had a related patch set uploaded (by Esanders):
Use VisualEditorSupportCheck

https://gerrit.wikimedia.org/r/289997

gerritbot added a project: Patch-For-Review.May 21 2016, 1:10 PM
Esanders added a project: Browser-Support-Internet-Explorer.May 21 2016, 2:08 PM
Paladox subscribed.May 21 2016, 3:25 PM
Danny_B moved this task from Unsorted to IE9 on the Browser-Support-Internet-Explorer board.May 21 2016, 3:58 PM
gerritbot added a comment.May 23 2016, 7:53 PM

Change 289997 merged by jenkins-bot:
Use VisualEditorSupportCheck

https://gerrit.wikimedia.org/r/289997

Jdforrester-WMF closed this task as Resolved.May 24 2016, 7:00 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited projects, added MW-1.28-release (WMF-deploy-2016-05-24_(1.28.0-wmf.3)); removed Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).May 31 2016, 8:01 PM
gerritbot added a comment.Jun 22 2016, 9:57 AM

Change 295462 had a related patch set uploaded (by Paladox):
Use VisualEditorSupportCheck

https://gerrit.wikimedia.org/r/295462

gerritbot added a project: Patch-For-Review.Jun 22 2016, 9:57 AM

Change 295463 had a related patch set uploaded (by Paladox):
Use VisualEditorSupportCheck

https://gerrit.wikimedia.org/r/295463

gerritbot added a comment.Jun 22 2016, 9:58 AM

Change 295463 abandoned by Paladox:
Use VisualEditorSupportCheck

https://gerrit.wikimedia.org/r/295463

gerritbot added a comment.Jun 22 2016, 10:26 AM

Change 295466 had a related patch set uploaded (by Paladox):
Use VisualEditorSupportCheck

https://gerrit.wikimedia.org/r/295466

gerritbot added a comment.Jun 23 2016, 6:15 PM

Change 295466 abandoned by Mattflaschen:
Use VisualEditorSupportCheck

Reason:
Doesn't exist in VE on REL1_26.

https://gerrit.wikimedia.org/r/295466

gerritbot added a comment.Jul 7 2016, 5:49 PM

Change 295462 merged by jenkins-bot:
Use VisualEditorSupportCheck

https://gerrit.wikimedia.org/r/295462

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL