Page MenuHomePhabricator
Create Task
Maniphest T135914

Valid composer.json for VisualEditor
Closed, DeclinedPublic
Actions

Description

Hello,

The composer.json for VisualEditor is not entirely valid:

./composer.json is valid for simple usage with composer but has
strict errors that make it unable to be published as a package:
See https://getcomposer.org/doc/04-schema.md for details on the schema
name : The property name is required
description : The property description is required
No license specified, it is recommended to do so. For closed-source software you may use "proprietary" as license.

This prevents the publishing of the extension on Packagist and makes it a lot less easy to install with Composer.
Here is an example of a valid composer.json file: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FLiquidThreads.git/master/composer.json

Regards,

Related Objects

Event Timeline

Rudloff created this task.May 21 2016, 3:50 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 21 2016, 3:50 PM
Paladox subscribed.May 21 2016, 4:44 PM

@Rudloff we use composer for tests not to publish on packagist.

Paladox added a subscriber: Legoktm.May 21 2016, 4:44 PM

Adding @Legoktm since I think you said no to do this for other extensions too.

Rudloff added a comment.May 21 2016, 4:57 PM

We had a discussion on T123363 and we agreed that using Composer autoloading feature to install extension is probably not a good thing for MediaWiki but that downloading extensions with Composer is harmless.
I personnaly think that it would be pretty useful as Composer is becoming the defacto standard for installing third-party PHP code.

Danny_B added a project: Composer.May 22 2016, 7:31 PM
Legoktm closed this task as Declined.May 23 2016, 4:04 AM

VisualEditor is intentionally not published on packagist.org. The composer.json is valid for what it's being used for.

• bd808 mentioned this in T178137: MediaWiki-Vendor creates a scenario in which incompatible versions of dependencies can be present.Oct 18 2017, 2:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits