Page MenuHomePhabricator
Create Task
Maniphest T135923

"Pi" article on mobile en.wp throws a 503 fatal
Closed, ResolvedPublic
Actions

Description

https://en.m.wikipedia.org/wiki/Pi?mobileaction=beta
Not sure why

https://en.m.wikipedia.org/wiki/Pi?mobileaction=stable
Is fine.

  • Find the issue
  • Fix the issue
  • SWAT the fix

Details

SubjectRepoBranchLines +/-
Use 1 XPath query rather than N+1 queriesmediawiki/extensions/MobileFrontendwmf/1.28.0-wmf.2+11 -10
Avoid fatals in reference edge casesmediawiki/extensions/MobileFrontendwmf/1.28.0-wmf.2+33 -5
Avoid fatals in reference edge casesmediawiki/extensions/MobileFrontendmaster+33 -5
Use 1 XPath query rather than N+1 queriesmediawiki/extensions/MobileFrontendmaster+11 -10
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.May 21 2016, 10:08 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 21 2016, 10:08 PM
• MZMcBride subscribed.May 21 2016, 10:12 PM
Aklapper renamed this task from Pi throws a 503 fatal to "Pi" article on mobile en.wp throws a 503 fatal.May 22 2016, 11:31 AM
dr0ptp4kt added a project: Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card.May 23 2016, 12:17 PM
Jdlrobson triaged this task as Unbreak Now! priority.May 23 2016, 4:26 PM
Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptMay 23 2016, 4:26 PM
• Jhernandez moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 23 2016, 4:26 PM
Jdlrobson updated the task description. (Show Details)May 23 2016, 4:27 PM
• Jhernandez subscribed.May 23 2016, 6:04 PM

Update core and MF to master, you'll find the issue happens in mobileaction=beta, but not in stable

Here's the exception:

2016-05-23 17:47:08 wiki fatal ERROR: [71f1a44c] PHP Fatal Error: Call to undefined method DOMText::getAttribute() {"exception_id":"71f1a44c"}
[Exception ErrorException] (/vagrant/mediawiki/extensions/MobileFrontend/includes/MobileFormatter.php:214) PHP Fatal Error: Call to undefined method DOMText::getAttribute()
  #0 /vagrant/mediawiki/extensions/MobileFrontend/includes/MobileFormatter.php(214): NO_FUNCTION_GIVEN()
  #1 /vagrant/mediawiki/extensions/MobileFrontend/includes/MobileFormatter.php(141): MobileFormatter->doRewriteReferencesForLazyLoading()
  #2 /vagrant/mediawiki/extensions/MobileFrontend/includes/MobileFrontend.body.php(71): MobileFormatter->filterContent(boolean, boolean, boolean)
  #3 /vagrant/mediawiki/extensions/MobileFrontend/includes/MobileFrontend.hooks.php(210): ExtMobileFrontend::DOMParse(OutputPage, string, boolean)
  #4 /vagrant/mediawiki/includes/Hooks.php(195): MobileFrontendHooks::onOutputPageBeforeHTML(OutputPage, string)
  #5 /vagrant/mediawiki/includes/OutputPage.php(1839): Hooks::run(string, array)
  #6 /vagrant/mediawiki/includes/OutputPage.php(1857): OutputPage->addParserOutputText(ParserOutput)
  #7 /vagrant/mediawiki/includes/page/Article.php(607): OutputPage->addParserOutput(ParserOutput)
  #8 /vagrant/mediawiki/includes/actions/ViewAction.php(44): Article->view()
  #9 /vagrant/mediawiki/includes/MediaWiki.php(504): ViewAction->show()
  #10 /vagrant/mediawiki/includes/MediaWiki.php(288): MediaWiki->performAction(Article, Title)
  #11 /vagrant/mediawiki/includes/MediaWiki.php(746): MediaWiki->performRequest()
  #12 /vagrant/mediawiki/includes/MediaWiki.php(520): MediaWiki->main()
  #13 /vagrant/mediawiki/index.php(43): MediaWiki->run()
  #14 /var/www/w/index.php(5): include(string)
  #15 {main}

Not sure what's changed under our feet...

Jdlrobson added a project: Web-Team-Backlog.May 23 2016, 6:10 PM
gerritbot subscribed.May 23 2016, 6:27 PM

Change 290286 had a related patch set uploaded (by Phuedx):
Add test case for T135923

https://gerrit.wikimedia.org/r/290286

gerritbot added a project: Patch-For-Review.May 23 2016, 6:27 PM
dr0ptp4kt moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.May 23 2016, 7:36 PM
Jdlrobson claimed this task.May 23 2016, 8:31 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 23 2016, 9:00 PM
gerritbot added a comment.May 24 2016, 9:01 AM

Change 290411 had a related patch set uploaded (by Phuedx):
Use 1 XPath query rather than N 1 queries

https://gerrit.wikimedia.org/r/290411

phuedx subscribed.May 24 2016, 9:04 AM

@Jdlrobson: Thanks for adding the additional test case. See 290411: Use 1 XPath query rather than N+1 queries for an alternative solution.

Jdlrobson merged a task: T136095: Fatal error: Call to undefined method DOMText::getAttribute() in /srv/mediawiki/php-1.28.0-wmf.2/extensions/MobileFrontend/includes/MobileFormatter.php on line 214.May 24 2016, 4:19 PM
Jdlrobson added a subscriber: aude.
gerritbot added a comment.May 24 2016, 5:22 PM

Change 290286 merged by jenkins-bot:
Avoid fatals in reference edge cases

https://gerrit.wikimedia.org/r/290286

gerritbot added a comment.May 24 2016, 5:28 PM

Change 290411 merged by jenkins-bot:
Use 1 XPath query rather than N 1 queries

https://gerrit.wikimedia.org/r/290411

Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 24 2016, 5:38 PM
gerritbot added a comment.May 24 2016, 9:33 PM

Change 290587 had a related patch set uploaded (by Jdlrobson):
Avoid fatals in reference edge cases

https://gerrit.wikimedia.org/r/290587

Jdlrobson added a comment.May 24 2016, 9:37 PM

In SWAT window.

gerritbot added a comment.May 24 2016, 10:37 PM

Change 290598 had a related patch set uploaded (by Dereckson):
Use 1 XPath query rather than N 1 queries

https://gerrit.wikimedia.org/r/290598

gerritbot added a comment.May 24 2016, 11:28 PM

Change 290587 merged by jenkins-bot:
Avoid fatals in reference edge cases

https://gerrit.wikimedia.org/r/290587

gerritbot added a comment.May 24 2016, 11:54 PM

Change 290598 merged by Dereckson:
Use 1 XPath query rather than N 1 queries

https://gerrit.wikimedia.org/r/290598

Stashbot subscribed.May 24 2016, 11:58 PM

Mentioned in SAL [2016-05-24T23:58:21Z] <dereckson@tin> Synchronized php-1.28.0-wmf.2/extensions/MobileFrontend/includes/MobileFormatter.php: "Pi" article on mobile en.wp throws a 503 fatal (T135923, [[Gerrit:290587]] + [[Gerrit:290598]]) (duration: 00m 24s)

Jdlrobson closed this task as Resolved.May 24 2016, 11:59 PM

verified in production

TerraCodes updated the task description. (Show Details)May 25 2016, 12:51 AM
ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-05-17_(1.28.0-wmf.2)), MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).May 31 2016, 9:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL