Page MenuHomePhabricator

ParserTest_LuaCommon__luaParserTests::testParserTest fails on master
Closed, ResolvedPublic

Description

23:29:06 1) ParserTest_LuaCommon__luaParserTests::testParserTest with data set #27 ('Scribunto: Strip markers in CSS', '{{#invoke:test|testStrippedCs...iki>}}', '<div style="color:#ff0000"></div>\n', '', '')
23:29:06 Scribunto: Strip markers in CSS
23:29:06 Failed asserting that two strings are equal.
23:29:06 --- Expected
23:29:06 +++ Actual
23:29:06 @@ @@
23:29:06 -'<div style="color:#ff0000"></div>
23:29:06 +'<div style="/* invalid control char */"></div>
23:29:06  '
23:29:06 
23:29:06 /mnt/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/includes/parser/NewParserTest.php:825
23:29:06 /mnt/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/MediaWikiTestCase.php:354

See: https://gerrit.wikimedia.org/r/#/c/290123/ and https://integration.wikimedia.org/ci/job/mwext-testextension-php55/11558/console

This also breaks some of the Wikibase jenkins jobs.

Event Timeline

hoo created this task.May 22 2016, 11:33 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 22 2016, 11:33 PM
hoo updated the task description. (Show Details)

Broken by rMW7e4a134f49d0: SECURITY: Include quote characters in strip markers so esc in attr, I guess the test should just be deleted. One less workaround for T14974, it looks like.

Umm, I thought I had already fixed this.

I guess

never got applied

Umm, I thought I had already fixed this.

Or I guess that would be you already fixed it ;)

Change 290157 had a related patch set uploaded (by Brian Wolff):
SECURITY: Don't escape strip markers when escaping attributes in mw.html

https://gerrit.wikimedia.org/r/290157

Change 290158 had a related patch set uploaded (by Brian Wolff):
SECURITY: Don't escape strip markers when escaping attributes in mw.html

https://gerrit.wikimedia.org/r/290158

Change 290159 had a related patch set uploaded (by Brian Wolff):
SECURITY: Don't escape strip markers when escaping attributes in mw.html

https://gerrit.wikimedia.org/r/290159

Change 290160 had a related patch set uploaded (by Brian Wolff):
SECURITY: Don't escape strip markers when escaping attributes in mw.html

https://gerrit.wikimedia.org/r/290160

Change 290157 merged by jenkins-bot:
SECURITY: Don't escape strip markers when escaping attributes in mw.html

https://gerrit.wikimedia.org/r/290157

hoo closed this task as Resolved.May 23 2016, 7:26 AM
hoo removed a project: Patch-For-Review.

Change 290159 merged by jenkins-bot:
SECURITY: Don't escape strip markers when escaping attributes in mw.html

https://gerrit.wikimedia.org/r/290159

Change 290158 merged by Brian Wolff:
SECURITY: Don't escape strip markers when escaping attributes in mw.html

https://gerrit.wikimedia.org/r/290158

Change 290160 merged by Brian Wolff:
SECURITY: Don't escape strip markers when escaping attributes in mw.html

https://gerrit.wikimedia.org/r/290160

Oh, we just forgot to merge the fix for Scribunto. Fun.