Page MenuHomePhabricator
Create Task
Maniphest T135982

Manage error in file upload window when file is too large
Closed, ResolvedPublic
Actions

Description

using the upload Window, when we try to upload a file too large, we get an incomprehensive error : 'SFUploadWindow::processVerificationError: Unknown value 12'

We should get a readable error 'Your file is too large'

Event Timeline

Pyro853 created this task.May 23 2016, 10:35 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 23 2016, 10:35 AM
Pyro853 added a comment.May 23 2016, 10:38 AM

I done a fix, but I fail to push it on gerrit. (account : pyro853) I got a the message :
! [remote rejected] upload-window-error -> upload-window-error (prohibited by Gerrit)

Is there a naming convention for the branches ?

I never push any code on gerrit, a little help would be great :)

Aklapper added a comment.May 23 2016, 3:08 PM

@Pyro853 : Which exact steps did you perform? Which Gerrit guide did you follow? Which command triggered that error?

Pyro853 added a comment.May 23 2016, 8:26 PM

hello,
Thanks for the link, i found many tutorials, but not this one, which is more detailed. I miss the 'git review' part.

I push my little correction

Yaron_Koren closed this task as Resolved.May 24 2016, 3:38 AM
Yaron_Koren claimed this task.
Yaron_Koren subscribed.

I checked in the fix - thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits