Page MenuHomePhabricator

Pulling patches from Phabricator does not give consistent commit hashes
Closed, DeclinedPublic

Description

arc patch-ing the same Differential twice gives you two different commits locally ... obviously with different commit hashes.

So if both John and Jill both pull a Differential into their respoctive local checkouts, they have no immediate way to see if they are looking at the same code, as they'll see different commit hashes.

(Note that they do see the number of the Differential (like D8), but they do not see the number of the Diff they received (E.g.: D8 has two different Diffs:

).)

When trying to help people with git, typically my first question is “At which commit hash are you?”, so I can reproduce their environment. With that ability gone, helping others with git becomes shooting in the dark, as it's hard to reproduce the state of their checkout.

See also T162: Commit hashes of landed patches need not match the latest ones shown in Differential

Details

Differential Revisions
D880: testing
Reference
fl227

Event Timeline

flimport raised the priority of this task from to Normal.
flimport set Reference to fl227.

pixelpapst wrote on 2014-06-14 13:53:04 (UTC)

I don't think there needs to be much discussion about this task. This clearly breaks some people's workflow, and makes the surface between git and arc more confusing.

I think this is ready to be filed upstream.

Qgil lowered the priority of this task from Normal to Low.Oct 9 2014, 11:12 PM
Qgil added a comment.Oct 10 2014, 11:45 AM

Sorry, the examples above were gone with the fab2phab migration.

If someone can reproduce this in http://phab-01.wmflabs.org, I can create a task for it upstream.

Mattflaschen-WMF raised the priority of this task from Low to Normal.Nov 7 2014, 5:14 AM
Qgil lowered the priority of this task from Normal to Low.Nov 27 2014, 7:57 AM

Currently Gerrit-Migration is in the queue of Phabricator subprojects after Project-Management and Gitblit-Deprecate. If someone wants to work on this task, take it and assign the priority accordingly.

Qgil set Security to None.
greg moved this task from To Triage to Backlog on the Differential board.Nov 4 2015, 7:23 PM
greg moved this task from To Triage to Tooling on the Gerrit-Migration board.Dec 2 2015, 12:30 AM
Qgil removed a subscriber: Qgil.Dec 2 2015, 11:50 AM

Theres a diff at https://phabricator.wikimedia.org/D880 if anyone wants to test this, idk how I manged to submit a diff on phab.wm.o for a repo on phab.wmflabs.o tho...

mmodell closed this task as Declined.Oct 31 2018, 7:37 PM