Page MenuHomePhabricator

Notice: Undefined variable: wgUseXVO in RawAction.php on line 96 (MW 1.23)
Closed, ResolvedPublic

Description

I get "Notice: Undefined variable: wgUseXVO in RawAction.php on line 96" when viewing action=raw using the latest MW 1.23 release.

T125283-REL1_23.patch broke MediaWiki 1.23's raw action because it uses $wgUseXVO in the onView() function where it is not yet declared. This may result in a PHP Notice which breaks things served via Raw action (e.g. the JavaScript we store and serve from MediaWiki).

I suggest changing
global $wgSquidMaxage, $wgForcedRawSMaxage;
to
global $wgSquidMaxage, $wgForcedRawSMaxage, $wgUseXVO;
at the start of the onView() function.

(Originally reported by @GreenReaper at T125283#2320859.)

Event Timeline

matmarex created this task.May 24 2016, 8:44 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 24 2016, 8:44 PM

Change 309855 had a related patch set uploaded (by Paladox):
Add missing global $wgUseXVO to RawAction.php

https://gerrit.wikimedia.org/r/309855

Change 309855 merged by jenkins-bot:
Add missing global $wgUseXVO to RawAction.php

https://gerrit.wikimedia.org/r/309855

Paladox closed this task as Resolved.Sep 15 2016, 11:12 PM
Paladox claimed this task.