Page MenuHomePhabricator

SelectFileWidget: Make 'File selection is not-supported' state clearer to user
Closed, ResolvedPublic

Description

The current message on not-supported SelectFileWidgets goes “File selection is not supported”.
This is a pretty ambiguous message to the user, it leaves the why completely open.

What are the browsers currently not-supported and how can we make it clearer to the user?
Is it file selection or file upload?

Event Timeline

@Anomie @Esanders Could you shed some light on when the not-supported state is triggered – when browser doesn't support input type=file, correct?

We also require support for HTML5 File API (http://caniuse.com/#feat=fileapi). Unsupported browsers include IE 9 and older, Safari 5 and older, and some older mobile browsers.

@matmarex @Esanders @Jdforrester-WMF Do we have any comparable message on another widget for missing browser support?

Volker_E lowered the priority of this task from Medium to Low.Jul 4 2016, 1:25 PM

We also require support for HTML5 File API (http://caniuse.com/#feat=fileapi). Unsupported browsers include IE 9 and older, Safari 5 and older, and some older mobile browsers.

I think I am missing something, don't we only check for input type=file in the isSupported method, and not for the File API?

In case the File API and/or drag drop isn't available, but input type=file is, should we degrade to a normal input? Sorry, I don't currently have a way to test this, so asking.

I think I am missing something, don't we only check for input type=file in the isSupported method, and not for the File API?

It checks that an <input type="file"> element can be created and that the element has the files property that is specified by the File API.

I think I am missing something, don't we only check for input type=file in the isSupported method, and not for the File API?

It checks that an <input type="file"> element can be created and that the element has the files property that is specified by the File API.

Ah, understood. Thanks @Anomie!

Volker_E renamed this task from SelectFileWidget: Make state of being 'not-supported' clearer to user to SelectFileWidget: Make 'File selection is not-supported' state clearer to user.Mar 30 2017, 11:20 PM
Volker_E lowered the priority of this task from Low to Lowest.
matmarex assigned this task to Esanders.

Resolved by removing this state in https://gerrit.wikimedia.org/r/c/oojs/ui/+/970277. We no longer support any browsers that SelectFileWidget wasn't compatible with.