Maniphest T136209

MediaViewer download button has mixed colors
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tgr
	May 25 2016, 3:55 PM

Tags

Referenced Files

	F4053712: mmv-color.png
	May 25 2016, 3:55 PM

Subscribers

Description

mmv-color.png (248×506 px, 35 KB)

The button has changed colors when the progressive class was removed as part of UI-Standardization but the dropdown target remained the same.

Details

	Subject	Repo	Branch	Lines +/-
	Fix obsolete `constructive` color on download button dropdown	mediawiki/extensions/MultimediaViewer	master	+11 -13

Customize query in gerrit

Related Objects

Duplicates Merged Here: T130354: Drop-down button colors not matching

Event Timeline

Tgr created this task.May 25 2016, 3:55 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 25 2016, 3:55 PM

@Volker_E looks like there is a custom element here - is there an OOjs UI / MediaWiki UI equivalent?

Jdlrobson changed the task status from Open to Stalled.May 25 2016, 5:11 PM

Jdlrobson triaged this task as Medium priority.

Jdlrobson added a project: Web-Team-Backlog.

@Jdlrobson Closest is a ButtonGroupWidget with a download button side-by-side a dropdown button

Change 290727 had a related patch set uploaded (by VolkerE):
Fix obsolete constructive color on download button dropdown

https://gerrit.wikimedia.org/r/290727

gerritbot added a project: Patch-For-Review.May 25 2016, 6:36 PM

Volker_E changed the task status from Stalled to Open.May 25 2016, 6:48 PM

Volker_E raised the priority of this task from Medium to High.

Volker_E merged a task: T130354: Drop-down button colors not matching.

Volker_E added subscribers: • Gilles, Pginer-WMF.

• jhobs moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.May 25 2016, 9:28 PM

Change 290727 merged by jenkins-bot:
Fix obsolete constructive color on download button dropdown

https://gerrit.wikimedia.org/r/290727

Jdlrobson closed this task as Resolved.May 25 2016, 10:14 PM

Jdlrobson claimed this task.

Volker_E claimed this task.May 25 2016, 10:50 PM

Volker_E edited projects, added UI-Standardization-Kanban; removed Patch-For-Review.

Volker_E moved this task from Backlog to Done on the UI-Standardization-Kanban board.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).May 31 2016, 10:01 PM

• Phabricator_maintenance moved this task from Triaged but Future to 2015-16 Q4 on the Web-Team-Backlog board.Mar 6 2018, 11:54 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptMar 6 2018, 11:54 PM