Page MenuHomePhabricator
Create Task
Maniphest T136238

Uncaught TypeError: Cannot read property 'getMainText' of null
Closed, ResolvedPublic
Actions

Description

Error counts between 2016-05-18 20:33:39 and 2016-05-24 17:15:38, for this and similar error messages:

76 Uncaught TypeError: Cannot read property 'getMainText' of null
15 Uncaught TypeError: Cannot call method 'getMainText' of null
13 TypeError: null is not an object (evaluating 'mw.Title.makeTitle(NS_CATEGORY,data).getMainText')
 3 Unable to get property 'getMainText' of undefined or null reference
 2 Die Eigenschaft "getMainText" eines undefinierten oder Nullverweises kann nicht abgerufen werden.

Details

SubjectRepoBranchLines +/-
mw.widgets.CategorySelector: Avoid JS exceptions for invalid user inputmediawiki/coremaster+10 -3
uw.CategoriesDetailsWidget: Avoid JS exceptions for invalid user inputmediawiki/extensions/UploadWizardmaster+3 -0
CapsuleMultiselectWidget: Allow ignoring user input for 'allowArbitrary' widgetsoojs/uimaster+18 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.May 25 2016, 7:42 PM
matmarex claimed this task.Jun 2 2016, 11:25 AM
matmarex triaged this task as Medium priority.

Looks like mw.widgets.CategorySelector to me…

matmarex added a comment.Jun 2 2016, 11:57 AM

This actually looks pretty ugly. OO.ui.CapsuleMultiselectWidget doesn't have a way to validate/reject user input. We'll need a bunch of fixes in a bunch of places…

gerritbot subscribed.Jul 4 2016, 6:52 PM

Change 297287 had a related patch set uploaded (by Bartosz Dziewoński):
CapsuleMultiselectWidget: Allow ignoring user input for 'allowArbitrary' widgets

https://gerrit.wikimedia.org/r/297287

gerritbot added a project: Patch-For-Review.Jul 4 2016, 6:52 PM

Change 297288 had a related patch set uploaded (by Bartosz Dziewoński):
mw.widgets.CategorySelector: Avoid JS exceptions for invalid user input

https://gerrit.wikimedia.org/r/297288

gerritbot added a comment.Jul 4 2016, 6:52 PM

Change 297289 had a related patch set uploaded (by Bartosz Dziewoński):
uw.CategoriesDetailsWidget: Avoid JS exceptions for invalid user input

https://gerrit.wikimedia.org/r/297289

gerritbot added a comment.Jul 5 2016, 9:46 AM

Change 297287 merged by jenkins-bot:
CapsuleMultiselectWidget: Allow ignoring user input for 'allowArbitrary' widgets

https://gerrit.wikimedia.org/r/297287

Jdforrester-WMF moved this task from Untriaged to Needs code review on the Multimedia board.Jul 7 2016, 2:03 PM
gerritbot added a comment.Jul 13 2016, 12:14 PM

Change 297288 merged by jenkins-bot:
mw.widgets.CategorySelector: Avoid JS exceptions for invalid user input

https://gerrit.wikimedia.org/r/297288

gerritbot added a comment.Jul 13 2016, 12:14 PM

Change 297289 merged by jenkins-bot:
uw.CategoriesDetailsWidget: Avoid JS exceptions for invalid user input

https://gerrit.wikimedia.org/r/297289

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)), MW-1.28-release-notes.Jul 13 2016, 1:00 PM
matmarex closed this task as Resolved.Jul 14 2016, 11:32 AM
matmarex removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL