Page MenuHomePhabricator
Create Task
Maniphest T136260

Match the style of maplink numbered boxes to the existing ones as used in WV
Closed, ResolvedPublic
Actions

Description

This page has a good comparison of the existing numbbered links with what <maplink> generates. We should match that style to simplify the migration

Also, I tried to do another template migration, with even uglier boxes. Feel free to play with the template

Copy of the template's CSS:

<span style="border:1px solid {{User:Yurik/Sandbox/TypeToColor|{{{type|listing}}}}}; background:{{User:Yurik/Sandbox/TypeToColor|{{{type|listing}}}}}; 
font-weight:bold; display:inline-block; width:2em; text-align:center; color:#fff;" title="Map for this '{{{type|listing}}}' marker">

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Kartographerwmf/1.28.0-wmf.5+2 -3Fixed <maplink> autostyling
mediawiki/extensions/Kartographermaster+2 -3Fixed <maplink> autostyling
mediawiki/extensions/Kartographermaster+28 -0Add class parameter to <maplink>
mediawiki/extensions/Kartographermaster+5 -0Match the style of maplink numbered boxes to the existing ones as used in wikivoyage.
Customize query in gerrit

Related Objects
Search...

Event Timeline

Yurik created this task.May 26 2016, 1:16 AM
Restricted Application added a project: Discovery. · View Herald TranscriptMay 26 2016, 1:16 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript
Yurik updated the task description. (Show Details)May 26 2016, 1:24 AM
Yurik moved this task from Unsorted to UI tasks on the Maps (Kartographer) board.May 26 2016, 9:59 PM
Yurik moved this task from All map-related tasks to Kartographer on the Maps board.May 27 2016, 12:00 AM
Yurik added a project: Maps-Sprint.May 27 2016, 3:18 PM
Yurik moved this task from Backlog to To-do on the Maps-Sprint board.May 27 2016, 10:25 PM
Yurik triaged this task as High priority.May 27 2016, 10:29 PM
Yurik added a parent task: T132971: Implement Kartographer customization to match Wikivoyage existing map.
JGirault claimed this task.May 31 2016, 9:34 PM
gerritbot added a subscriber: gerritbot.May 31 2016, 11:04 PM

Change 292055 had a related patch set uploaded (by JGirault):
Match the style of maplink numbered boxes to the existing ones as used in wikivoyage.

https://gerrit.wikimedia.org/r/292055

gerritbot added a project: Patch-For-Review.May 31 2016, 11:04 PM
JGirault added a subscriber: Volker_E.May 31 2016, 11:25 PM

Here is the suggested design of the maplink box:

Screen Shot 2016-05-31 at 4.17.34 PM.png (662×1 px, 91 KB)

/cc @Volker_E : note that I used --bdc-heading #ccc for the border, which in my opinion looks a bit nicer than the darker --bdc-base #222. See screenshot below using #222:

Screen Shot 2016-05-31 at 4.19.48 PM.png (658×1 px, 92 KB)

JGirault moved this task from To-do to Needs review on the Maps-Sprint board.May 31 2016, 11:25 PM
gerritbot added a comment.Jun 1 2016, 9:53 PM

Change 292055 merged by jenkins-bot:
Match the style of maplink numbered boxes to the existing ones as used in wikivoyage.

https://gerrit.wikimedia.org/r/292055

Yurik closed this task as Resolved.Jun 1 2016, 9:57 PM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).Jun 1 2016, 10:00 PM
Yurik reopened this task as Open.Jun 2 2016, 11:53 AM

Nope, found a bug - http://vem4.wmflabs.org/wiki/PoiTest -- the colors do not match. Also, I don't think we should make link box that big - lets keep it inline with the existing styles as defined by the community - I wouldn't want to fight two battles at the same time - the styling and migration :) See styling at https://en.wikivoyage.org/wiki/Salzburg#See

Yurik added a comment.EditedJun 2 2016, 1:01 PM

@JGirault @MaxSem I'm not exactly sure how to proceed, lets discuss.

  • For WV, we need an ability to simplify the switchover, which means we must match the existing style exactly. Which means that for an autonumbered maplinks, we should generate colored boxes that look identical to existing ones. Note that this usecase is always behind a template, so we can use any kind of complex template-based html generation here.
  • For "geohack" replacement, we need to generate geo coordinates as a simple clickable text (we already do that) - as seen at the top right here.
  • For other usecases, we can introduce any kind of format we think are good.

For VW, the marker template figures out the color itself, so it can generate something like this:

<maplink ... style="background: #0f0f0f">{ ... "marker-color": "#0f0f0f" ...} </>

Which would generate

<a class="mw-kartographer mw-kartographer-link" style="background: #0f0f0f;" ... >...</a>

Without the style parameter, <maplink> would generate the same html but without the "style" parameter. We could also allow class attribute. Thoughts?

JGirault created subtask T136890: Maplink extractMarkerCss does not extract the color hex code correctly .Jun 2 2016, 9:39 PM
Yurik closed subtask T136890: Maplink extractMarkerCss does not extract the color hex code correctly as Resolved.Jun 2 2016, 11:15 PM
Yurik added a comment.EditedJun 3 2016, 6:19 PM

Another discussion with @MaxSem:

<maplink ... class="maplink-restaurant">{ ... "marker-color": "#0f0f0f" ...} </>

Which would generate

<a class="mw-kartographer mw-kartographer-link maplink-restaurant">...</a>

Lets remove the automatic style generation and put it behind a feature flag (disabled for now)

gerritbot added a comment.Jun 3 2016, 6:54 PM

Change 292603 had a related patch set uploaded (by MaxSem):
Add class parameter to <maplink>

https://gerrit.wikimedia.org/r/292603

gerritbot added a comment.Jun 3 2016, 7:08 PM

Change 292603 merged by jenkins-bot:
Add class parameter to <maplink>

https://gerrit.wikimedia.org/r/292603

gerritbot added a comment.Jun 8 2016, 1:59 AM

Change 293252 had a related patch set uploaded (by Yurik):
Fixed <maplink> styling

https://gerrit.wikimedia.org/r/293252

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)).Jun 8 2016, 3:01 PM
gerritbot added a comment.Jun 8 2016, 7:23 PM

Change 293360 had a related patch set uploaded (by Yurik):
Fixed <maplink> autostyling

https://gerrit.wikimedia.org/r/293360

gerritbot added a comment.Jun 8 2016, 7:58 PM

Change 293252 merged by jenkins-bot:
Fixed <maplink> autostyling

https://gerrit.wikimedia.org/r/293252

gerritbot added a comment.Jun 8 2016, 7:58 PM

Change 293360 merged by jenkins-bot:
Fixed <maplink> autostyling

https://gerrit.wikimedia.org/r/293360

Yurik closed this task as Resolved.Jun 9 2016, 4:06 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL