Page MenuHomePhabricator
Create Task
Maniphest T136267

Switching from source section editing to visual editing says "Discard my changes and switch" without explaining why
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Switching from source section editing to visual editing says "Discard my changes and switch" without explaining why, and it's confusing because switching from editing a whole article preserves the changes. It would be nice to explain it (if you cannot fix the discarding issue).

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+6 -0ve.init.mw.ArticleTarget: Skip prompt when switching to VE from NWE section editing if unchanged
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.May 26 2016, 6:28 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 26 2016, 6:28 AM
Esanders added a subscriber: Esanders.May 27 2016, 12:07 PM

That would only happen on a wiki not using RestBASE. Is this a WMF wiki?

Amire80 added a comment.May 27 2016, 12:21 PM
In T136267#2333404, @Esanders wrote:

That would only happen on a wiki not using RestBASE. Is this a WMF wiki?

The English Wikipedia :)

Esanders added a comment.May 27 2016, 5:02 PM

Oh - source section editing. I misread.

Elitre added a subscriber: Elitre.May 27 2016, 5:08 PM
Jdforrester-WMF triaged this task as Low priority.May 31 2016, 7:17 PM
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
jberkel added a subscriber: jberkel.Mar 27 2018, 8:13 PM
jberkel added a comment.Mar 27 2018, 8:16 PM

It always displays "Discard my changes and switch", even without changes. Which means that you need two clicks to switch to visual editor.

DLynch mentioned this in T200386: Switching to VE from New Section tab shows the confirmation dialog with option "Discard my changes and switch" when no changes were actually made. .Aug 2 2018, 4:13 PM
Jdforrester-WMF merged a task: T200386: Switching to VE from New Section tab shows the confirmation dialog with option "Discard my changes and switch" when no changes were actually made. .Aug 10 2018, 6:07 PM
Jdforrester-WMF added subscribers: Ryasmeen, matmarex, DLynch and 2 others.
gerritbot added a comment.Aug 10 2018, 6:08 PM

Change 449642 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.init.mw.ArticleTarget: Skip prompt when switching to VE from NWE section editing if unchanged

https://gerrit.wikimedia.org/r/449642

gerritbot added a project: Patch-For-Review.Aug 10 2018, 6:08 PM
Jdforrester-WMF assigned this task to matmarex.Aug 10 2018, 6:08 PM
Jdforrester-WMF edited projects, added VisualEditor (Current work); removed VisualEditor.
Jdforrester-WMF moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Aug 14 2018, 4:09 PM

Change 449642 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.init.mw.ArticleTarget: Skip prompt when switching to VE from NWE section editing if unchanged

https://gerrit.wikimedia.org/r/449642

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 5:00 PM
Jdforrester-WMF moved this task from Code review to QA on the VisualEditor (Current work) board.Aug 14 2018, 5:26 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 8:55 PM
Ryasmeen added a project: Verified.Aug 15 2018, 12:33 AM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
Deskana closed this task as Resolved.Aug 16 2018, 1:39 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 16 2018, 1:39 PM
matmarex mentioned this in T202586: confusing error message.Aug 23 2018, 2:43 PM
matmarex merged a task: T202586: confusing error message.
matmarex added subscribers: • aripstra, ggellerman.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL