Page MenuHomePhabricator

Add ellipsis to the extract when the text overflows.
Closed, DuplicatePublic

Description

Currently Page-Previews doesn't do anything about text overflowing the popup, it should have an ellipsis at the end or some other text overflow thing to indicate the text continues.

CSS-only solutions mostly suck: https://css-tricks.com/line-clampin/

  • text-overflow only works on single line elements
  • With text-align: justify we could probably hack something up, but it is ugly (example)
  • There's browser-specific things that we can add to improve the experience in a few browsers (webkit based ones). See caniuse.com/#feat=css-line-clamp
  • We can do the classic fade-out (example), which I think we've used before.

Needs input from Design to see what we should do.

Event Timeline

Restricted Application added a subscriber: Zppix. · View Herald TranscriptMay 26 2016, 10:40 AM
Jhernandez updated the task description. (Show Details)May 26 2016, 10:52 AM
Jdlrobson triaged this task as Normal priority.May 26 2016, 5:14 PM
Jdlrobson added a project: Readers-Web-Backlog.
Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.

@dr0ptp4kt merged a task: T67845: Hovercards: Fix the length of the extract, and add gradient

Looks like the merge happened the wrong way around.

I'll do the needful. Hold tight, folks.