[Task] Allow constructing all kinds of entity IDs from numbers
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	thiemowmde
	May 26 2016, 1:21 PM

Description

https://github.com/wmde/WikibaseDataModel/pull/670 proposes an Int32EntityId interface as a clean way to deconstruct an EntityId into a number. However, this interface is optional and not blocking us since we can do the same via method_exists( …, 'getNumericId' ).

What's blocking us now (see https://gerrit.wikimedia.org/r/#/c/290461/1/lib/includes/Store/Sql/SqlEntityInfoBuilder.php) is the fact that we do not have a service to reconstruct an EntityId from an entity type (or a prefix) and a number. Currently we do this with LegacyIdInterpreter::newIdFromTypeAndNumber (used 8 times in production), but this static method can't learn new entity types.

Patches for review:

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Make TermIndexEntry::getNumericId private	mediawiki/extensions/Wikibase	master	+3 -4
Make all term index based services support new entity types	mediawiki/extensions/Wikibase	master	+156 -33
Add missing message and composer configuration	mediawiki/extensions/WikibaseMediaInfo	master	+6 -1
Merge "Split entity-id-builder-pair config into pattern and builder"	mediawiki/extensions/WikibaseMediaInfo	master	+0 -0
Introduce EntityIdComposer and "entity-id-composer"	mediawiki/extensions/Wikibase	master	+250 -8

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Duplicate		None	T66288 basic support for structured data on mediawiki files
Invalid		Lydia_Pintscher	T76012 make use of new entity type for multimedia / structured data of media files
Open		None	T109579 [Epic] Give more sister projects access to Wikidata
Open		None	T187900 There is no way to reference a specific quote on Wikiquote
Stalled		None	T71753 [Story] Wikibase / Wikidata support on Wikiquote
Open		None	T67626 [Epic] Support for queries on-wiki (automated list generation)
Resolved		Addshore	T76019 [Story] Support new types of Entities in Wikibase Client
Resolved		thiemowmde	T135650 [Task] Migrate PropertySuggester away from assuming all entities are numeric
Resolved		Addshore	T75496 [Epic] Support new types of Entities in Wikibase Repository
Resolved		thiemowmde	T136294 [Task] Allow constructing all kinds of entity IDs from numbers

Event Timeline

thiemowmde created this task.May 26 2016, 1:21 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMay 26 2016, 1:21 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript

Change 290930 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Introduce FragmentedEntityIdBuilder and "fragmented-entity-id-builder"

https://gerrit.wikimedia.org/r/290930

gerritbot added a project: Patch-For-Review.May 26 2016, 1:22 PM

thiemowmde added a parent task: T135650: [Task] Migrate PropertySuggester away from assuming all entities are numeric.May 26 2016, 1:28 PM

thiemowmde moved this task from Proposed to Review on the Wikidata-Sprint-2016-05-24 board.

Addshore moved this task from incoming to in progress on the Wikidata board.May 26 2016, 3:07 PM

Change 290930 merged by jenkins-bot:
Introduce EntityIdComposer and "entity-id-composer"

https://gerrit.wikimedia.org/r/290930

Change 292141 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Make all term index based services support new entity types

https://gerrit.wikimedia.org/r/292141

thiemowmde added a parent task: T75496: [Epic] Support new types of Entities in Wikibase Repository.Jun 1 2016, 2:18 PM

Change 292144 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Merge "Split entity-id-builder-pair config into pattern and builder"

https://gerrit.wikimedia.org/r/292144

thiemowmde mentioned this in rEWBI2a7459c8d442: Merge "Split entity-id-builder-pair config into pattern and builder".Jun 1 2016, 2:24 PM

Change 292145 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add missing message and composer configuration

https://gerrit.wikimedia.org/r/292145

thiemowmde mentioned this in rEWBI1f67a3c9fbc2: Add missing message and composer configuration.Jun 1 2016, 2:28 PM

Change 292144 abandoned by Thiemo Mättig (WMDE):
Merge "Split entity-id-builder-pair config into pattern and builder"

https://gerrit.wikimedia.org/r/292144

Change 292145 abandoned by Thiemo Mättig (WMDE):
Add missing message and composer configuration

https://gerrit.wikimedia.org/r/292145

Change 292141 merged by jenkins-bot:
Make all term index based services support new entity types

https://gerrit.wikimedia.org/r/292141

• Jonas closed this task as Resolved.Jun 13 2016, 1:57 PM

• Jonas moved this task from Review to Done on the Wikidata-Sprint-2016-05-24 board.

Change 295224 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Make TermIndexEntry::getNumericId private

https://gerrit.wikimedia.org/r/295224

Change 295224 merged by jenkins-bot:
Make TermIndexEntry::getNumericId private