Page MenuHomePhabricator
Create Task
Maniphest T136357

is_js_only attribute is not valid and should be removed from HTML output - fails validation
Closed, ResolvedPublic
Actions

Description

The Minerva skin is mostly w3c compliant except one error:
https://validator.w3.org/nu/?doc=http%3A%2F%2Fen.m.wikipedia.beta.wmflabs.org%2Fwiki%2FTimeline_of_the_presidency_of_Barack_Obama_%282010%29
"Attribute is_js_only not allowed on element a at this point."

This is a shame and should be fixed.
I'm not sure what this is here for so should be removed from the HTML output

Details

SubjectRepoBranchLines +/-
Remove the 'is_js_only' attribute from page actions links HTMLmediawiki/extensions/MobileFrontendmaster+5 -2
Customize query in gerrit

Event Timeline

Jdlrobson created this task.May 26 2016, 8:11 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 26 2016, 8:11 PM
Danny_B moved this task from Unsorted to Needs removal on the Technical-Debt board.May 26 2016, 8:23 PM
Danny_B subscribed.May 26 2016, 8:28 PM

Introduced in https://gerrit.wikimedia.org/r/#/c/281551/

Danny_B added a subscriber: • bmansurov.May 26 2016, 8:29 PM
Agabi10 subscribed.May 26 2016, 8:49 PM
TheDJ subscribed.May 27 2016, 7:41 AM

you can use a data-mw prefixed attribute, which are sanitized.

TheDJ added a comment.May 27 2016, 7:43 AM

although... isn't this why we have the .client-js and .client-nojs classes ? Why is the attribute needed at all ?

• bmansurov added a comment.EditedMay 27 2016, 1:40 PM
In T136357#2333005, @TheDJ wrote:

although... isn't this why we have the .client-js and .client-nojs classes ? Why is the attribute needed at all ?

You're right. This was meant to be used as a flag to use one of the classes you mentioned. It was not supposed to be output with the HTML. An oversight on my end.

Danny_B triaged this task as High priority.May 27 2016, 1:41 PM
Jdlrobson raised the priority of this task from High to Needs Triage.May 27 2016, 10:02 PM
Jdlrobson added a project: good first task.

Not sure this is high. Will consult with the devs on Mon/Tuesday. Easy fix if anyone wants to volunteer a patch over the weekend (I'd love you forever :-))

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 27 2016, 10:02 PM
gerritbot subscribed.May 27 2016, 10:52 PM

Change 291370 had a related patch set uploaded (by Bmansurov):
Remove the 'is_js_only' attribute from page actions links HTML

https://gerrit.wikimedia.org/r/291370

gerritbot added a project: Patch-For-Review.May 27 2016, 10:52 PM
gerritbot added a comment.May 27 2016, 11:17 PM

Change 291370 merged by jenkins-bot:
Remove the 'is_js_only' attribute from page actions links HTML

https://gerrit.wikimedia.org/r/291370

Jdlrobson closed this task as Resolved.May 30 2016, 4:21 PM
Jdlrobson claimed this task.
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).Jun 1 2016, 12:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL