Page MenuHomePhabricator
Create Task
Maniphest T136361

Let no-JS users mark notifications (or notification groups) as read without explicitly seeing a separate form
Closed, ResolvedPublic
Actions

Description

The no-JS user should not visibly navigate to another page when marking notifications as read from the special page.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
No-JS special page: One-click mark as readmediawiki/extensions/Echomaster+190 -22
OOUI HTMLForm: Allow specifying whether buttons are framedmediawiki/coremaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Mattflaschen-WMF created this task.May 26 2016, 9:14 PM
Restricted Application added subscribers: Zppix, Luke081515. · View Herald TranscriptMay 26 2016, 9:14 PM
• Mattflaschen-WMF moved this task from Untriaged to In Development on the Collab-Team-2016-Apr-Jun-Q4 board.May 26 2016, 9:37 PM
Catrope added a comment.May 27 2016, 1:05 AM

We could do this, but it would require "mark as read" to be a button that submits a form. We can't (well, shouldn't) mark notifications as read from a GET request.

• Mattflaschen-WMF added a comment.May 27 2016, 1:23 AM
In T136361#2332691, @Catrope wrote:

We could do this, but it would require "mark as read" to be a button that submits a form. We can't (well, shouldn't) mark notifications as read from a GET request.

Yep, understood. That's the approach I'm using.

gerritbot added a comment.May 28 2016, 12:05 AM

Change 291382 had a related patch set uploaded (by Mattflaschen):
OOUI HTMLForm: Allow specifying whether buttons are framed

https://gerrit.wikimedia.org/r/291382

gerritbot added a project: Patch-For-Review.May 28 2016, 12:05 AM
gerritbot added a comment.May 28 2016, 12:12 AM

Change 291383 had a related patch set uploaded (by Mattflaschen):
No-JS special page: One-click mark as read

https://gerrit.wikimedia.org/r/291383

gerritbot added a comment.May 28 2016, 3:54 PM

Change 291382 merged by jenkins-bot:
OOUI HTMLForm: Allow specifying whether buttons are framed

https://gerrit.wikimedia.org/r/291382

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).Jun 1 2016, 1:00 AM
Catrope moved this task from In Development to QA Review on the Collab-Team-2016-Apr-Jun-Q4 board.Jun 1 2016, 6:11 PM
gerritbot added a comment.Jun 1 2016, 6:21 PM

Change 291383 merged by jenkins-bot:
No-JS special page: One-click mark as read

https://gerrit.wikimedia.org/r/291383

Etonkovidova added a comment.Jun 1 2016, 9:32 PM

Checked in betalabs - One-click mark as read is in place.

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-2016-Apr-Jun-Q4 board.Jun 1 2016, 9:32 PM
• jmatazzoni closed this task as Resolved.Jun 1 2016, 9:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits