Page MenuHomePhabricator

Empty flyout is missing a text placeholder
Closed, ResolvedPublic

Description

I am sure there used to be something like "You have no notifications." in an empty flyout. Now there is only an empty grey area.

Event Timeline

Catrope moved this task from Untriaged to Ready for Pickup on the Collab-Team-2016-Apr-Jun-Q4 board.
Catrope added a subscriber: Mooeypoo.
Catrope added a subscriber: Catrope.

There's also a JS error when the API request fails (HTTP 500 in my case because I was messing around with ApiEchoNotifications.php). I fixed that, but the flyout is still empty.

Change 291672 had a related patch set uploaded (by Catrope):
Fix JS error when API request errors

https://gerrit.wikimedia.org/r/291672

Change 291672 merged by jenkins-bot:
Fix JS error when API request fails

https://gerrit.wikimedia.org/r/291672

Change 291834 had a related patch set uploaded (by Mooeypoo):
Display error message on API failure or empty result

https://gerrit.wikimedia.org/r/291834

Change 291834 merged by jenkins-bot:
Display error message on API failure or empty result

https://gerrit.wikimedia.org/r/291834

Checked in betalabs - "There are no notifications." is displayed in all cases when there are no notifications.

Screen Shot 2016-05-30 at 4.16.41 PM.png (214×575 px, 25 KB)

Also, checked the case when a new user signs up to a foreign wiki and disables cross-wiki notifications - previously there were some hiccups like displaying empty placeholder for Alerts.

Screen Shot 2016-05-24 at 6.34.35 PM.png (201×615 px, 22 KB)

Now "There are no notifications." is always displayed for such cases.