Page MenuHomePhabricator

Empty flyout is missing a text placeholder
Closed, ResolvedPublic

Description

I am sure there used to be something like "You have no notifications." in an empty flyout. Now there is only an empty grey area.

Event Timeline

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 28 2016, 9:23 AM
Catrope moved this task from Untriaged to Ready for Pickup on the Collab-Team-2016-Apr-Jun-Q4 board.
Catrope added a subscriber: Mooeypoo.
Catrope added a subscriber: Catrope.

There's also a JS error when the API request fails (HTTP 500 in my case because I was messing around with ApiEchoNotifications.php). I fixed that, but the flyout is still empty.

Change 291672 had a related patch set uploaded (by Catrope):
Fix JS error when API request errors

https://gerrit.wikimedia.org/r/291672

Change 291672 merged by jenkins-bot:
Fix JS error when API request fails

https://gerrit.wikimedia.org/r/291672

Change 291834 had a related patch set uploaded (by Mooeypoo):
Display error message on API failure or empty result

https://gerrit.wikimedia.org/r/291834

Change 291834 merged by jenkins-bot:
Display error message on API failure or empty result

https://gerrit.wikimedia.org/r/291834

Checked in betalabs - "There are no notifications." is displayed in all cases when there are no notifications.

Also, checked the case when a new user signs up to a foreign wiki and disables cross-wiki notifications - previously there were some hiccups like displaying empty placeholder for Alerts.

Now "There are no notifications." is always displayed for such cases.

jmatazzoni closed this task as Resolved.May 31 2016, 3:33 PM