Page MenuHomePhabricator
Create Task
Maniphest T136467

Empty flyout is missing a text placeholder
Closed, ResolvedPublic
Actions

Description

I am sure there used to be something like "You have no notifications." in an empty flyout. Now there is only an empty grey area.

Details

SubjectRepoBranchLines +/-
Display error message on API failure or empty resultmediawiki/extensions/Echomaster+15 -6
Fix JS error when API request failsmediawiki/extensions/Echomaster+3 -1
Customize query in gerrit

Event Timeline

matej_suchanek created this task.May 28 2016, 9:23 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 28 2016, 9:23 AM
Catrope added a project: Collab-Team-2016-Apr-Jun-Q4.May 29 2016, 9:16 PM
Catrope moved this task from Untriaged to Ready for Pickup on the Collab-Team-2016-Apr-Jun-Q4 board.
Catrope added a subscriber: Mooeypoo.
Catrope subscribed.

There's also a JS error when the API request fails (HTTP 500 in my case because I was messing around with ApiEchoNotifications.php). I fixed that, but the flyout is still empty.

gerritbot subscribed.May 29 2016, 9:18 PM

Change 291672 had a related patch set uploaded (by Catrope):
Fix JS error when API request errors

https://gerrit.wikimedia.org/r/291672

gerritbot added a project: Patch-For-Review.May 29 2016, 9:18 PM
gerritbot added a comment.May 30 2016, 8:59 AM

Change 291672 merged by jenkins-bot:
Fix JS error when API request fails

https://gerrit.wikimedia.org/r/291672

Catrope removed a project: Patch-For-Review.May 30 2016, 7:55 PM
gerritbot added a comment.May 30 2016, 9:52 PM

Change 291834 had a related patch set uploaded (by Mooeypoo):
Display error message on API failure or empty result

https://gerrit.wikimedia.org/r/291834

gerritbot added a project: Patch-For-Review.May 30 2016, 9:52 PM
Mooeypoo claimed this task.May 30 2016, 9:54 PM
Mooeypoo moved this task from Ready for Pickup to Needs Review on the Collab-Team-2016-Apr-Jun-Q4 board.
Catrope moved this task from Needs Review to QA Review on the Collab-Team-2016-Apr-Jun-Q4 board.May 30 2016, 10:05 PM
gerritbot added a comment.May 30 2016, 10:12 PM

Change 291834 merged by jenkins-bot:
Display error message on API failure or empty result

https://gerrit.wikimedia.org/r/291834

Etonkovidova subscribed.May 30 2016, 11:33 PM

Checked in betalabs - "There are no notifications." is displayed in all cases when there are no notifications.

Screen Shot 2016-05-30 at 4.16.41 PM.png (214×575 px, 25 KB)

Also, checked the case when a new user signs up to a foreign wiki and disables cross-wiki notifications - previously there were some hiccups like displaying empty placeholder for Alerts.

Screen Shot 2016-05-24 at 6.34.35 PM.png (201×615 px, 22 KB)

Now "There are no notifications." is always displayed for such cases.

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-2016-Apr-Jun-Q4 board.May 30 2016, 11:33 PM
• jmatazzoni closed this task as Resolved.May 31 2016, 3:33 PM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).Jun 1 2016, 2:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL