Page MenuHomePhabricator
Create Task
Maniphest T136513

Different results of Page.getVersion() between compat and core
Closed, ResolvedPublic
Actions

Description

Page.getVersionHistory() gives a list of tuples but core has 4 items whereas compat gives tuples with 6 items.

Details

SubjectRepoBranchLines +/-
[cleanup] Desupport Page.getVersionHistory() methodpywikibot/coremaster+23 -9
[doc] Update breaking change info for getVersionHistorypywikibot/coremaster+5 -2
[compat2core] return compat-like list of tuples from getVersionHistorypywikibot/coremaster+4 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Xqt created this task.May 29 2016, 8:51 AM
Restricted Application added subscribers: pywikibot-bugs-list, Zppix, Aklapper. · View Herald TranscriptMay 29 2016, 8:51 AM
Xqt triaged this task as Unbreak Now! priority.May 29 2016, 8:51 AM
Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptMay 29 2016, 8:51 AM
Xqt closed this task as Invalid.May 29 2016, 9:05 AM
This comment was removed by Xqt.
Xqt reopened this task as Open.May 29 2016, 9:14 AM
Xqt lowered the priority of this task from Unbreak Now! to High.
Xqt added a project: Pywikibot-compat-to-core.

reopened. This is a breaking change between compat and core. compat had a tuple of 6 items: revision id, edit date/time, user name, edit summary, size and tags (see doc string) but core has 4 items only.

Xqt added a comment.May 29 2016, 9:26 AM

The change was done in compat with https://www.mediawiki.org/wiki/Special:Code/pywikipedia/8556 but wasn't ported to core.

Xqt renamed this task from Page.getVersion() gives wong results to Different results of Page.getVersion() between compat and core.May 29 2016, 9:41 AM
Xqt updated the task description. (Show Details)
Xqt updated the task description. (Show Details)May 29 2016, 7:22 PM
gerritbot subscribed.May 29 2016, 7:33 PM

Change 291605 had a related patch set uploaded (by Xqt):
[compat2core] return compat-like list of tuples from getVersionHistory

https://gerrit.wikimedia.org/r/291605

gerritbot added a project: Patch-For-Review.May 29 2016, 7:33 PM
Xqt added a parent task: T151110: RFC: Regressions of core should be rethought or solved.Nov 24 2016, 10:11 AM
gerritbot added a comment.Mar 6 2017, 4:16 PM

Change 291605 had a related patch set uploaded (by xqt):
[pywikibot/core] [compat2core] return compat-like list of tuples from getVersionHistory

https://gerrit.wikimedia.org/r/291605

Xqt claimed this task.Mar 6 2017, 4:26 PM
gerritbot added a comment.Jan 16 2018, 11:29 AM

Change 404435 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [compat2core] Note different results of getVersionHistory

https://gerrit.wikimedia.org/r/404435

Xqt mentioned this in T183085: [RfC] Drop compat module.Jun 17 2018, 7:21 PM
xSavitar moved this task from Backlog to Needs Review on the Pywikibot board.Nov 5 2018, 11:30 AM
Xqt mentioned this in T213287: Drop support of Python 2.7.Jun 30 2019, 5:31 PM
gerritbot added a comment.Mar 29 2020, 10:03 AM

Change 291605 abandoned by Xqt:
[compat2core] return compat-like list of tuples from getVersionHistory

Reason:
getVersionHistory is deprecated

https://gerrit.wikimedia.org/r/291605

Xqt closed this task as Declined.Mar 29 2020, 10:06 AM

getVersionHistory is deprecated; Page.revisions() should be used instead.

Xqt reopened this task as Open.Mar 29 2020, 10:08 AM

getVersionHistory might be dropped and removed due to multiple breaking changes in core

Xqt lowered the priority of this task from High to Low.Mar 29 2020, 10:08 AM
gerritbot added a comment.Mar 29 2020, 10:19 AM

Change 404435 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [doc] Update breaking change info for getVersionHistory

https://gerrit.wikimedia.org/r/404435

gerritbot added a comment.Mar 29 2020, 10:58 AM

Change 584194 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [cleanup] Desupport Page.getVersionHistory() method

https://gerrit.wikimedia.org/r/584194

TerraCodes unsubscribed.Mar 29 2020, 8:32 PM
gerritbot added a comment.Apr 26 2020, 12:46 AM

Change 404435 merged by jenkins-bot:
[pywikibot/core@master] [doc] Update breaking change info for getVersionHistory

https://gerrit.wikimedia.org/r/404435

Xqt mentioned this in rPWBC7f4e4c9818c8: [doc] Update breaking change info for getVersionHistory.Apr 26 2020, 12:47 AM
gerritbot added a comment.Apr 26 2020, 7:06 AM

Change 584194 merged by jenkins-bot:
[pywikibot/core@master] [cleanup] Desupport Page.getVersionHistory() method

https://gerrit.wikimedia.org/r/584194

Xqt mentioned this in rPWBC2c89bea82cea: [cleanup] Desupport Page.getVersionHistory() method.Apr 26 2020, 7:08 AM
Xqt closed this task as Resolved.Apr 26 2020, 7:12 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL