Page MenuHomePhabricator

Remove section title lines on the Notification Page
Closed, ResolvedPublic

Description

The list of notifications in the Notifications Page is grouped by days, and each group is labelled by the date.
Currently those headers (e.g. "18 May 2016" in the example below) have a bottom border:

Given that the notifications in the list already form a visible block, the line seems to just add noise, and should be removed.

The screenshot below shows the list without the lines (i.e., removing the bottom-border property of ".mw-echo-ui-datedNotificationsWidget .mw-echo-ui-subGroupListWidget-header" ):

The additional bottom space that was added below the "Mark group as read" button (".mw-echo-ui-subGroupListWidget-header-row-markAllReadButton"), should be also removed.

Event Timeline

Pginer-WMF removed a project: Design.
Pginer-WMF updated the task description. (Show Details)May 30 2016, 6:59 PM
Mooeypoo moved this task from Untriaged to Needs Review on the Collab-Team-2016-Apr-Jun-Q4 board.

Change 291854 had a related patch set uploaded (by Mooeypoo):
Styling changes to Special:Notifications headers and toolbar

https://gerrit.wikimedia.org/r/291854

Change 291854 merged by jenkins-bot:
Styling changes to Special:Notifications headers and toolbar

https://gerrit.wikimedia.org/r/291854

Checked in betalabs - section underline is removed.

jmatazzoni closed this task as Resolved.Jun 1 2016, 8:10 PM