Page MenuHomePhabricator

ButtonGroupWidget with two adjacent disabled buttons should show a dividing line between the buttons
Closed, ResolvedPublic1 Estimated Story Points


When both of pagination arrow buttons are in disabled state - the dividing line between them is missing.

Screen Shot 2016-05-30 at 11.01.32 AM.png (396×1 px, 34 KB)

Screen Shot 2016-05-30 at 11.07.50 AM.png (387×1 px, 67 KB)

Compare with the other states - when only one button is in disabled state and when both buttons are active:

Screen Shot 2016-05-30 at 11.08.07 AM.png (376×1 px, 60 KB)

Screen Shot 2016-05-30 at 11.08.27 AM.png (242×1 px, 39 KB)

Event Timeline

This is definitely interesting for UI-Standardization (and @Volker_E)

For the Specific case of the notification Page, the idea was to hide those controls when there is just one page to show, which also result in never showing both controls disabled at the same time.
More details in T136574: Hide pagination controls from the Notification Page when there is only one page

This looks like a bug in OOUI, moving it there.

Catrope renamed this task from [betalbs] mw-echo-ui-notificationsInboxWidget-toolbar-pagination-buttons should display a dividing border in disabled state to ButtonGroupWidget with two adjacent disabled buttons should show a dividing line between the buttons.May 30 2016, 7:52 PM

Change 291823 had a related patch set uploaded (by VolkerE):
MediaWiki theme: Adjacent disabled ButtonGroup/SelectWidget buttons border

The patch set is a quick fix, adding a white border when two disabled buttons in a ButtonGroupWidget/ButtonSelectWidget are adjacent.
@Pginer-WMF M101 is currently speaking a different language (not-implemented) when it comes to disabled elements, featuring non-filled backgrounds and just disabled text color. I see advantages in that approach, we should take this on our list of topics for the offsite.

Jdforrester-WMF assigned this task to Volker_E.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from Backlog to OOjs-UI-0.17.3 on the OOUI board.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.3); removed OOUI.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.

Change 291823 merged by jenkins-bot:
MediaWiki theme: Adjacent disabled ButtonGroup/SelectWidget buttons border

Checked in betalabs

  • there is a change in design - when there are messages only for one page, the pagination is not displayed anymore
  • the dividing line is displayed when the next page is being loaded, e,g,

Screen Shot 2016-06-01 at 9.44.32 AM.png (180×263 px, 13 KB)

@Etonkovidova I'm not sure that I understand your last comment. Pagination not displayed should be in no connection to the above merged patch set.
Please clarify what you mean by your second sentence…

@Volker_E - the different functionality was added for pagination - a user with less than 50 notifications won't see the button widget anymore.