Page MenuHomePhabricator

AbuseFilter warnings are shown while translating in ContentTranslation for filters that don't affect publishing
Closed, ResolvedPublic

Description

AbuseFilter warnings are shown while translating in ContentTranslation when any filter is triggered. This is overkill, and it causes issues such as T132258 and T136540.

The idea of showing warnings in ContentTranslation is to help users avoid issues that don't allow them to publish. Some filter only are only for statistics and logging and not for content blocking, and ContentTranslation must ignore them.

It's easy to query for info about an AbuseFilter by using the list=abusefilters query with the filter number and asking for "actions" in the "abfprop" parameter.

I could find the following actions:

'flag',
'throttle',
'warn',
'disallow',
'blockautopromote',
'block',
'degroup',
'tag'

CX must definitely show warnings for "disallow" and "block". It may show warnings for "throttle", "warn", "blockautopromote" and "degroup", because it may hint that the action would be disruptive. It must not show warnings for filters that only do "flag" or "tag" (but of course it must show warnings for filters that do both "tag" and "disallow").

Event Timeline

Arrbee triaged this task as Medium priority.Jun 1 2016, 7:24 AM

Change 292352 had a related patch set uploaded (by Nikerabbit):
Do not warn users about AbuseFilter rules that do not affect publishing

https://gerrit.wikimedia.org/r/292352

Change 292352 merged by jenkins-bot:
Do not warn users about AbuseFilter rules that do not affect publishing

https://gerrit.wikimedia.org/r/292352