Page MenuHomePhabricator
Create Task
Maniphest T136597

cxserver: update to service-template-node v0.4.0
Closed, ResolvedPublic
Actions

Description

As per https://lists.wikimedia.org/pipermail/services/2016-May/000052.html

Service-template-node v0.3.2~[1] has been released. This is an important
update for all services that contact the MW Action API or RESTBase, as it
brings a unified way of dealing with such requests. To make requests
against the MW API use apiUtil.mwApiGet() (from lib/api-utils.js), while
for RESTBase there is apiUtil.restApiGet().

Additionally, as per https://lists.wikimedia.org/pipermail/services/2016-July/000067.html:

service-template-node v0.4.0 has just been released~[1]. The new version
represents an important security and feature upgrade from v0.3.2 and you
are urged to update as soon as possible~[2].

Details

SubjectRepoBranchLines +/-
Update with service-template-node v0.4.0 changesmediawiki/services/cxservermaster+452 -276
Customize query in gerrit

Related Objects

Event Timeline

• santhosh created this task.May 31 2016, 6:37 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 31 2016, 6:37 AM
KartikMistry added a project: Language-Q4-2016-Sprint 4.May 31 2016, 6:39 AM
• mobrovac added a comment.May 31 2016, 8:49 AM

FYI, it would probably be best for you if you switched from tabs to 4 spaces in the source code repo, as that would ease updating, but would also be aligned with the way code in other services' repos is structured.

• santhosh triaged this task as Medium priority.Jun 1 2016, 4:59 AM
• santhosh added a comment.Jun 6 2016, 4:43 AM

FYI, it would probably be best for you if you switched from tabs to 4 spaces in the source code repo, as that would ease updating, but would also be aligned with the way code in other services' repos is structured.

That is just one difference in formatting. cxserver uses the MediaWiki js coding convention with same jshint/jscs/jsbeautify wikimedia presets. Apparently other services are not using it. Using same conventions in MW extension and services has some advantages for us.

• santhosh added a comment.Jun 6 2016, 6:20 AM

@mobrovac I came across this issue while working on this task https://github.com/wikimedia/service-template-node/issues/61

• santhosh claimed this task.Jun 6 2016, 6:21 AM
• santhosh moved this task from Backlog to Blocked on the Language-Q4-2016-Sprint 4 board.
gerritbot subscribed.Jun 6 2016, 6:24 AM

Change 292894 had a related patch set uploaded (by Santhosh):
WIP: Use api-util from service-template-node for RESTBase API

https://gerrit.wikimedia.org/r/292894

gerritbot added a project: Patch-For-Review.Jun 6 2016, 6:24 AM
• santhosh moved this task from Blocked to In Review on the Language-Q4-2016-Sprint 4 board.Jun 6 2016, 6:32 AM

@mobrovac I came across this issue while working on this task https://github.com/wikimedia/service-template-node/issues/61

My mistake. works with updated swagger-router.

Arrbee edited projects, added Language-Q4-2016-Sprint 5; removed Language-Q4-2016-Sprint 4.Jun 14 2016, 7:32 AM
Arrbee moved this task from Backlog to In Review on the Language-Q4-2016-Sprint 5 board.
Amire80 moved this task from Needs Triage to CX9 on the ContentTranslation board.Jun 20 2016, 6:57 AM
Arrbee added projects: Language-Q1-2016-17 Sprint 1, Language-Engineering July-September 2016.Jul 5 2016, 6:50 AM
Arrbee removed a project: Language-Q4-2016-Sprint 5.Jul 5 2016, 6:59 AM
Arrbee moved this task from Backlog to In Review on the Language-Q1-2016-17 Sprint 1 board.Jul 5 2016, 7:07 AM
Amire80 moved this task from CX9 to CX10 (July-Sep. 2016) on the ContentTranslation board.Jul 20 2016, 6:13 AM
Arrbee added a project: Language-Q1-2016-17 Sprint 2.Jul 20 2016, 6:34 AM
Arrbee removed a project: Language-Q1-2016-17 Sprint 1.
Arrbee moved this task from Backlog to In Review on the Language-Q1-2016-17 Sprint 2 board.Jul 20 2016, 6:42 AM
Amire80 added a project: Essential-Work.Jul 22 2016, 12:22 PM
• mobrovac renamed this task from cxserver: update to service-template-node v0.3.2 to cxserver: update to service-template-node v0.4.0.Jul 22 2016, 3:05 PM
• mobrovac updated the task description. (Show Details)
• mobrovac added projects: Services, User-mobrovac.Jul 22 2016, 3:16 PM

Here is the list of commits that are not included in CXServer:

  • a511596 - Release v0.4.0 (#68)
  • 8cd10c3 - remove in-tree docs; link to on-wiki documentation (#62)
  • 55bdde9 - Automatically send metrics for each incoming request (#67)
  • 6a46cb4 - Include core-js and bump service-runner to v2.0.4
  • aab8a57 - Check for vulnerabilities with nsp on npm test (#65)
  • 82886c8 - Update depenedencies
  • 18e3f61 - Use Node 4.4.6 for building the deploy repo and Travis (#64)
  • 3ac418b - Update to service-runner@v2 (#63)
  • bc51980 - Add library functions for accessing the MW and REST APIs (#60)
  • bba84b2 - doc fix: marked createRouter() param as optional
  • 6f6c95a - Report the incoming request on every log line
  • 8d2d86e - Minor improvements and release v0.3.1 (#56)
  • 4b1e772 - Release v0.3.0 (#55)
  • 05bf8f4 - Regenerate static/index.html (#54)
  • ead353f - Docs: document the deploy.submodule configuration directive
  • ede1db1 - Release v0.2.3
  • 7ee56e7 - Update dependencies
  • 81255a0 - Temp: Skip the failing gzipped content test
  • c05ddb9 - Travis YAML: Remove iojs testing and add Node 5.1
  • 56e21c3 - Set the default build target to 'debian'
  • 01eb28f - Logger: Log the stack trace only for 500 errors
  • d30a2b6 - CSP Headers: Allow the configuration of sending the security headers

https://gerrit.wikimedia.org/r/#/c/292894 currently contains only partially bc51980 and 01eb28f, but the other commits are still missing. Please go through the list and include them.

Amire80 moved this task from Backlog to Deployment preparation on the ContentTranslation-CXserver board.Jul 25 2016, 11:13 AM
Danny_B added a project: Language-Team.Jul 29 2016, 1:30 PM
Danny_B removed a subscriber: Language-Team.
Amire80 moved this task from Backlog to CX10 on the Language-Engineering July-September 2016 board.Jul 31 2016, 11:28 AM
• santhosh added a comment.Aug 1 2016, 6:12 AM

Updated the patch as follows:

In T136597#2487319, @mobrovac wrote:

Here is the list of commits that are not included in CXServer:

  • a511596 - Release v0.4.0 (#68)
  • 8cd10c3 - remove in-tree docs; link to on-wiki documentation (#62)

NA

  • 55bdde9 - Automatically send metrics for each incoming request (#67)

Present in https://gerrit.wikimedia.org/r/#/c/292894/

  • 6a46cb4 - Include core-js and bump service-runner to v2.0.4

Done in https://gerrit.wikimedia.org/r/#/c/292894/

  • aab8a57 - Check for vulnerabilities with nsp on npm test (#65)

Present in https://gerrit.wikimedia.org/r/#/c/292894/

  • 82886c8 - Update depenedencies

Present in https://gerrit.wikimedia.org/r/#/c/292894/

  • 18e3f61 - Use Node 4.4.6 for building the deploy repo and Travis (#64)

Travis not applicable. Node version update present in Present in https://gerrit.wikimedia.org/r/#/c/292894/

  • 3ac418b - Update to service-runner@v2 (#63)

Present in https://gerrit.wikimedia.org/r/#/c/292894/

  • bc51980 - Add library functions for accessing the MW and REST APIs (#60)

https://gerrit.wikimedia.org/r/#/c/292894/5/utils/api-util.js

  • bba84b2 - doc fix: marked createRouter() param as optional

Present in https://gerrit.wikimedia.org/r/#/c/292894/5/utils/util.js

  • 6f6c95a - Report the incoming request on every log line

https://gerrit.wikimedia.org/r/#/c/292894/5/utils/util.js

  • 8d2d86e - Minor improvements and release v0.3.1 (#56)

NA

  • 4b1e772 - Release v0.3.0 (#55)

NA

  • 05bf8f4 - Regenerate static/index.html (#54)

NA

  • ead353f - Docs: document the deploy.submodule configuration directive

NA

  • ede1db1 - Release v0.2.3

NA

  • 7ee56e7 - Update dependencies

In sync. Had updated in https://github.com/wikimedia/mediawiki-services-cxserver/commit/7382ee7698ceb3087abc836dff0af0ae8872561f and fresh update at https://gerrit.wikimedia.org/r/#/c/292894/

  • 81255a0 - Temp: Skip the failing gzipped content test

No such test in cxserver

  • c05ddb9 - Travis YAML: Remove iojs testing and add Node 5.1

cxserver does not use Travis yet

  • 56e21c3 - Set the default build target to 'debian'

It is debian in cxserver master https://github.com/wikimedia/mediawiki-services-cxserver/blob/master/package.json#L56

  • 01eb28f - Logger: Log the stack trace only for 500 errors

Present in https://gerrit.wikimedia.org/r/#/c/292894/

  • d30a2b6 - CSP Headers: Allow the configuration of sending the security headers

Present in https://gerrit.wikimedia.org/r/#/c/292894/

https://gerrit.wikimedia.org/r/#/c/292894 currently contains only partially bc51980 and 01eb28f, but the other commits are still missing. Please go through the list and include them.

Arrbee edited projects, added Language-Q1-2016-17 Sprint 3; removed Language-Q1-2016-17 Sprint 2.Aug 2 2016, 6:57 AM
Arrbee moved this task from Backlog to In Review on the Language-Q1-2016-17 Sprint 3 board.Aug 3 2016, 5:42 AM
Arrbee moved this task from In Review to Blocked on the Language-Q1-2016-17 Sprint 3 board.Aug 10 2016, 7:03 AM
gerritbot added a comment.Aug 11 2016, 11:35 AM

Change 292894 merged by jenkins-bot:
Update with service-template-node v0.4.0 changes

https://gerrit.wikimedia.org/r/292894

• mobrovac closed this task as Resolved.Aug 15 2016, 1:22 PM

Change has been merged, resolving. Thnx @santhosh !

Note: deployment is pending, to go out with https://gerrit.wikimedia.org/r/#/c/304444/ .

Nikerabbit moved this task from Blocked to Done on the Language-Q1-2016-17 Sprint 3 board.Aug 16 2016, 6:34 AM
KartikMistry added a comment.Aug 16 2016, 6:50 AM

https://phabricator.wikimedia.org/T143075 is task to deploy this changeset.

Amire80 edited projects, added ContentTranslation-Release10; removed Patch-For-Review.Sep 13 2016, 12:20 PM
Amire80 moved this task from Backlog to Infrastructure WMF requirements on the ContentTranslation-Release10 board.Sep 13 2016, 5:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL