Page MenuHomePhabricator

EditWatchlist fails on BETA wmflabs
Closed, ResolvedPublic

Description

Steps to reproduce:

  1. Log in
  2. http://de.wikipedia.beta.wmflabs.org/wiki/Special:EditWatchlist

For a week now it fails with the traceback below.

Either config problem at wmflabs deployment or special page code modified.

Recent changes (watchlist) not affected.

Exception encountered, of type "Wikimedia\Assert\ParameterTypeException"
[V01xrApEEaoAAGxX1zoAAAAB] /wiki/Spezial:Beobachtungsliste_bearbeiten Wikimedia\Assert\ParameterTypeException from line 89 of /srv/mediawiki/php-master/vendor/wikimedia/assert/src/Assert.php: Bad value for parameter $dbkey: must be a string
Backtrace:
#0 /srv/mediawiki/php-master/includes/title/TitleValue.php(76): Wikimedia\Assert\Assert::parameterType(string, integer, string)
#1 /srv/mediawiki/php-master/includes/cache/LinkBatch.php(171): TitleValue->__construct(integer, integer)
#2 /srv/mediawiki/php-master/includes/cache/LinkBatch.php(135): LinkBatch->addResultToCache(LinkCache, ResultWrapper)
#3 /srv/mediawiki/php-master/includes/cache/LinkBatch.php(122): LinkBatch->executeInto(LinkCache)
#4 /srv/mediawiki/php-master/includes/specials/SpecialEditWatchlist.php(385): LinkBatch->execute()
#5 /srv/mediawiki/php-master/includes/specials/SpecialEditWatchlist.php(541): SpecialEditWatchlist->getWatchlistInfo()
#6 /srv/mediawiki/php-master/includes/specials/SpecialEditWatchlist.php(151): SpecialEditWatchlist->getNormalForm()
#7 /srv/mediawiki/php-master/includes/specials/SpecialEditWatchlist.php(130): SpecialEditWatchlist->executeViewEditWatchlist()
#8 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(479): SpecialEditWatchlist->execute(boolean)
#9 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(591): SpecialPage->run(NULL)
#10 /srv/mediawiki/php-master/includes/MediaWiki.php(282): SpecialPageFactory::executePath(Title, RequestContext)
#11 /srv/mediawiki/php-master/includes/MediaWiki.php(746): MediaWiki->performRequest()
#12 /srv/mediawiki/php-master/includes/MediaWiki.php(520): MediaWiki->main()
#13 /srv/mediawiki/php-master/index.php(43): MediaWiki->run()
#14 /srv/mediawiki/w/index.php(3): include(string)
#15 {main}

Event Timeline

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 31 2016, 3:56 PM

T99736 is not related.

matmarex claimed this task.Jun 1 2016, 8:10 PM

This is a bug in 682116760198a7420a809e0b9966ecdc63f1c67d (https://gerrit.wikimedia.org/r/#/c/290166/). This exception happens on every page which would, if it was working, contain a red link (to a non-existent page) whose title consists only of numbers (0-9).

hahah, nice one. Thanks @matmarex, I totally didn't see that.

Change 292215 had a related patch set uploaded (by Bartosz Dziewoński):
LinkBatch: Cast array keys to string when constructing TitleValue

https://gerrit.wikimedia.org/r/292215

Change 292217 had a related patch set uploaded (by 20after4):
LinkBatch: Cast array keys to string when constructing TitleValue

https://gerrit.wikimedia.org/r/292217

Change 292215 merged by jenkins-bot:
LinkBatch: Cast array keys to string when constructing TitleValue

https://gerrit.wikimedia.org/r/292215

Change 292217 merged by jenkins-bot:
LinkBatch: Cast array keys to string when constructing TitleValue

https://gerrit.wikimedia.org/r/292217

mmodell closed this task as Resolved.Jun 1 2016, 8:41 PM

Working fine again. Thanks.

And, yes, I'm watching http://de.wikipedia.beta.wmflabs.org/wiki/Vorlage:0