EditWatchlist fails on BETA wmflabs
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

For a week now it fails with the traceback below.

Either config problem at wmflabs deployment or special page code modified.

Recent changes (watchlist) not affected.

Exception encountered, of type "Wikimedia\Assert\ParameterTypeException"
[V01xrApEEaoAAGxX1zoAAAAB] /wiki/Spezial:Beobachtungsliste_bearbeiten Wikimedia\Assert\ParameterTypeException from line 89 of /srv/mediawiki/php-master/vendor/wikimedia/assert/src/Assert.php: Bad value for parameter $dbkey: must be a string
Backtrace:
#0 /srv/mediawiki/php-master/includes/title/TitleValue.php(76): Wikimedia\Assert\Assert::parameterType(string, integer, string)
#1 /srv/mediawiki/php-master/includes/cache/LinkBatch.php(171): TitleValue->__construct(integer, integer)
#2 /srv/mediawiki/php-master/includes/cache/LinkBatch.php(135): LinkBatch->addResultToCache(LinkCache, ResultWrapper)
#3 /srv/mediawiki/php-master/includes/cache/LinkBatch.php(122): LinkBatch->executeInto(LinkCache)
#4 /srv/mediawiki/php-master/includes/specials/SpecialEditWatchlist.php(385): LinkBatch->execute()
#5 /srv/mediawiki/php-master/includes/specials/SpecialEditWatchlist.php(541): SpecialEditWatchlist->getWatchlistInfo()
#6 /srv/mediawiki/php-master/includes/specials/SpecialEditWatchlist.php(151): SpecialEditWatchlist->getNormalForm()
#7 /srv/mediawiki/php-master/includes/specials/SpecialEditWatchlist.php(130): SpecialEditWatchlist->executeViewEditWatchlist()
#8 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(479): SpecialEditWatchlist->execute(boolean)
#9 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(591): SpecialPage->run(NULL)
#10 /srv/mediawiki/php-master/includes/MediaWiki.php(282): SpecialPageFactory::executePath(Title, RequestContext)
#11 /srv/mediawiki/php-master/includes/MediaWiki.php(746): MediaWiki->performRequest()
#12 /srv/mediawiki/php-master/includes/MediaWiki.php(520): MediaWiki->main()
#13 /srv/mediawiki/php-master/index.php(43): MediaWiki->run()
#14 /srv/mediawiki/w/index.php(3): include(string)
#15 {main}

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	LinkBatch: Cast array keys to string when constructing TitleValue	mediawiki/core	master	+1 -1
	LinkBatch: Cast array keys to string when constructing TitleValue	mediawiki/core	wmf/1.28.0-wmf.4	+1 -1

Customize query in gerrit

Revisions and Commits

rMW MediaWiki
	Audited	rMW682116760198 LinkBatch: Use TitleValue instead of Title

Related Objects

Mentioned In: T136797: Unable to get edits of ip addresses in CU
T136705: Special:ListUsers is broken
T136650: Bad value for parameter $dbkey: must be a string
Mentioned Here: rMW977e80261368: LinkBatch: Cast array keys to string when constructing TitleValue
rMW682116760198: LinkBatch: Use TitleValue instead of Title
T99736: Special:Categories on some wikis errors out with "Exception encountered, of type "Wikimedia\Assert\ParameterAssertionException"

Event Timeline

PerfektesChaos created this task.May 31 2016, 3:56 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 31 2016, 3:56 PM

Krenair edited projects, added Beta-Cluster-reproducible; removed Beta-Cluster-Infrastructure.May 31 2016, 4:36 PM

Krenair mentioned this in T136650: Bad value for parameter $dbkey: must be a string.May 31 2016, 10:56 PM

matmarex mentioned this in T136705: Special:ListUsers is broken.Jun 1 2016, 7:41 PM

T99736 is not related.

matmarex merged tasks: T136705: Special:ListUsers is broken, T136650: Bad value for parameter $dbkey: must be a string.Jun 1 2016, 8:09 PM

matmarex added subscribers: • mmodell, greg, thcipriani and 5 others.

• mmodell added a commit: rMW682116760198: LinkBatch: Use TitleValue instead of Title.Jun 1 2016, 8:10 PM

This is a bug in 682116760198a7420a809e0b9966ecdc63f1c67d (https://gerrit.wikimedia.org/r/#/c/290166/). This exception happens on every page which would, if it was working, contain a red link (to a non-existent page) whose title consists only of numbers (0-9).