ReleaseTaggerBot broke on May 24
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Catrope
	May 31 2016, 5:26 PM

Description

@ReleaseTaggerBot hasn't made any changes to Phabricator since May 24.

Details

	Subject	Repo	Branch	Lines +/-
	Make Bug: parsing more lenient	labs/tools/forrestbot	master	+55 -5
	Make Bug: parsing more lenient	labs/tools/forrestbot	master	+46 -4

Customize query in gerrit

Related Objects

Mentioned In: T136633: Support multi-task commits

Event Timeline

Catrope created this task.May 31 2016, 5:26 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 31 2016, 5:26 PM

Catrope triaged this task as Unbreak Now! priority.May 31 2016, 5:26 PM

Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptMay 31 2016, 5:26 PM

Paladox subscribed.May 31 2016, 5:27 PM

Traceback (most recent call last):
  File "/data/project/forrestbot/forrestbot/forrestbot.py", line 223, in <module>
    for task, acts in itertools.groupby(sorted(actions, key=key), key=key):
  File "/data/project/forrestbot/forrestbot/forrestbot.py", line 221, in key
    return int(x['task'].strip()[1:])
ValueError: invalid literal for int() with base 10: '51256, T110143, T78456'

We don't support multi-bug commits at all at the moment (if there are multiple Bug: entries, the earlier ones get overwritten). I think the best 'right now' solution is to change the code to find the first 'Txxxx' entry (regex), and leaving the multi-task support for later.

valhallasw mentioned this in T136633: Support multi-task commits.May 31 2016, 6:31 PM

Change 291965 had a related patch set uploaded (by Merlijn van Deen):
Make Bug: parsing more lenient

https://gerrit.wikimedia.org/r/291965

gerritbot added a project: Patch-For-Review.May 31 2016, 7:02 PM

Change 291965 abandoned by Merlijn van Deen:
Make Bug: parsing more lenient

https://gerrit.wikimedia.org/r/291965

Change 291966 had a related patch set uploaded (by Merlijn van Deen):
Make Bug: parsing more lenient

https://gerrit.wikimedia.org/r/291966

Change 291966 merged by jenkins-bot:
Make Bug: parsing more lenient

https://gerrit.wikimedia.org/r/291966

valhallasw closed this task as Resolved.May 31 2016, 7:24 PM

valhallasw claimed this task.