public static function onSkinPreloadExistence( array &$titles, Skin $skin ) {
$context = MobileContext::singleton();
if ( $context->shouldDisplayMobileView() && !$context->isBlacklistedPage() ) {
$skin->getOutput()->setTarget( 'mobile' );
}
return true;
}The hook is documented as "Supply titles that should be added to link existence cache before the page is rendered". MobileFrontend is abusing it to do something totally different.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Don't set RL target in SkinPreloadExistence handler | mediawiki/extensions/MobileFrontend | master | +5 -20 |
The hook is documented as "Supply titles that should be added to link existence cache before the page is rendered". MobileFrontend is abusing it to do something totally different.
Apart from invalidating the contract of that hook is this blocking work / causing any issues in the cluster right now?
Change 295770 had a related patch set uploaded (by Jdlrobson):
Don't abuse SkinPreloadExistence to set mobile target
Change 295770 merged by jenkins-bot:
Don't set RL target in SkinPreloadExistence handler