https://grafana-admin.wikimedia.org/dashboard/db/edit-stash shows that even without bots not being counted, the cache hit rate is 25% or so. It would be nice to get this up.
Also related is what can be done to exclude more case that don't matter (e.g. doRollback()) from skewing the numbers.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | aaron | T136678 Investigate how to increase edit stash hit rate | |||
| Open | None | T137338 Make mobile web editor use edit stashing | |||
| Open | None | T137340 Make mobile app editor use edit stashing | |||
| Resolved | aaron | T137698 Plugin AbuseFilter::checkAllFilters pre-caching into the edit stash hook | |||
| Resolved | Krinkle | T137900 Deal with poor edit stash hit rate due to Lua modules using {{REVISIONID}} | |||
| Open | None | T138022 Parser warnings should contain location information |
Change 292520 had a related patch set uploaded (by Aaron Schulz):
Avoid rollback and bot flagged edits in edit stash stats
Change 292977 had a related patch set uploaded (by Aaron Schulz):
Avoid rollback and bot flagged edits in edit stash stats
Change 292977 merged by jenkins-bot:
Avoid rollback and bot flagged edits in edit stash stats
Change 292520 merged by Aaron Schulz:
Avoid rollback and bot flagged edits in edit stash stats
Change 293030 had a related patch set uploaded (by Aaron Schulz):
Make edit stash keys less preference sensitive
Change 293033 had a related patch set uploaded (by Aaron Schulz):
Make edit stash keys less preference sensitive
Change 293050 had a related patch set uploaded (by Aaron Schulz):
Flag internal page retrieve/save cycles with EDIT_INTERNAL
Change 293341 had a related patch set uploaded (by Aaron Schulz):
Flag internal page retrieve/save cycles with EDIT_INTERNAL
Change 293359 had a related patch set uploaded (by Aaron Schulz):
Perform edit stashing for ?undo and ?oldid reverts
Change 293050 merged by jenkins-bot:
Flag internal page retrieve/save cycles with EDIT_INTERNAL
Change 293341 merged by jenkins-bot:
Flag internal page retrieve/save cycles with EDIT_INTERNAL
Change 293683 had a related patch set uploaded (by Aaron Schulz):
Improvements to {{REVISIONUSER}} handling
Change 293880 had a related patch set uploaded (by Aaron Schulz):
Perform edit stashing for ?undo and ?oldid reverts
Change 293359 merged by jenkins-bot:
Perform edit stashing for ?undo and ?oldid reverts
Change 293963 had a related patch set uploaded (by Aaron Schulz):
Perform edit stashing for ?undo and ?oldid reverts
Change 293963 merged by jenkins-bot:
Perform edit stashing for ?undo and ?oldid reverts
Change 294294 had a related patch set uploaded (by Aaron Schulz):
Perform edit stashing when the edit preview or diff form is requested
Change 294294 merged by jenkins-bot:
Perform edit stashing when the edit preview or diff form is requested
Change 294369 had a related patch set uploaded (by Aaron Schulz):
Improvements to {{REVISIONUSER}} handling
Change 294382 had a related patch set uploaded (by Aaron Schulz):
Perform edit stashing when the edit preview or diff form is requested
Change 294382 merged by jenkins-bot:
Perform edit stashing when the edit preview or diff form is requested
Change 294414 had a related patch set uploaded (by Aaron Schulz):
Use a low TTL for parser output when special pages are included
Change 294415 had a related patch set uploaded (by Aaron Schulz):
Use a low TTL for parser output when special pages are included
Change 294414 merged by jenkins-bot:
Use a low TTL for parser output when special pages are included
Change 294416 had a related patch set uploaded (by Aaron Schulz):
Use a low TTL for parser output when special pages are included
Change 294416 merged by jenkins-bot:
Use a low TTL for parser output when special pages are included
Change 294415 merged by jenkins-bot:
Use a low TTL for parser output when special pages are included
<<+channel:StashEdit +wiki:enwiki +message:*no_ttl*>> is nearly empty. The cause of stash skipping is var_revision almost entirely. Fixing that could get us to ~2 hits/sec
Aside from that, between the lack of android/ios and mobile site stashing and some JS tools doing reverts, I think we have plenty to go on. All of these have subtasks.
Change 295023 had a related patch set uploaded (by Aaron Schulz):
Improve edit stashing when vary-revision is used
Change 295024 had a related patch set uploaded (by Aaron Schulz):
Improve edit stashing when vary-revision is used
Change 295024 merged by jenkins-bot:
Improve edit stashing when vary-revision is used
Change 295023 merged by jenkins-bot:
Improve edit stashing when vary-revision is used
Change 293880 abandoned by Aaron Schulz:
[WIP] Backend edit stashing for ?undo and ?oldid reverts
Reason:
Went with front-end patch