Regression: Menu issues in opera mini
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 1 2016, 3:12 PM

Description

Elements in the menu are off.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix main menu rasterized icon regression	mediawiki/extensions/MobileFrontend	master	+6 -26

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	None	T143916 [EPIC] Better support for low grade/remote browsers needed
Duplicate	None	T136802 [Epic] Make Wikipedia work on remote browsers (UC mini and Opera mini)
Duplicate	None	T136699 [EPIC] Improve look and feel and UX for searching on Opera Mini
Resolved	phuedx	T136706 Regression: Menu issues in opera mini

Event Timeline

Jdlrobson created this task.Jun 1 2016, 3:12 PM

Jdlrobson renamed this task from Menu issues in opera mini to Tracking: Menu issues in opera mini.Jun 1 2016, 5:09 PM

Jdlrobson renamed this task from Tracking: Menu issues in opera mini to Menu issues in opera mini.

Jdlrobson added a project: Tracking-Neverending.

Jdlrobson removed a project: Tracking-Neverending.

• bmansurov added a project: Web-Team-Backlog-Archived.Jun 1 2016, 5:11 PM

Jdlrobson renamed this task from Menu issues in opera mini to Regression: Menu issues in opera mini.Jun 1 2016, 9:16 PM

Jdlrobson added a project: Regression.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Design.

@Peter, do you mean, besides the icon placements, we need to add some space above the menu?

@Nirzar, what do you think the design should be? Design

Jdlrobson triaged this task as Medium priority.Jun 1 2016, 9:17 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson edited projects, added Reading-Web-Sprint-74-Page-views-page-views-PAGE-VIEWS; removed Design.

Jdlrobson moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog-Archived board.Jun 1 2016, 9:19 PM

@bmansurov i think it's about icons getting cut off and nothing more? if that's the only issue, it should just not be cut off :) @Jdlrobson is that correct?

Confirming in @Jdlrobson's stead, yes, it's the buttons getting cut off.

• Jhernandez moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-74-Page-views-page-views-PAGE-VIEWS board.Jun 6 2016, 4:34 PM

• Jhernandez moved this task from Ready for Signoff to Needs Analysis on the Reading-Web-Sprint-74-Page-views-page-views-PAGE-VIEWS board.Jun 6 2016, 4:40 PM

dr0ptp4kt set the point value for this task to 3.Jun 6 2016, 4:49 PM

dr0ptp4kt changed the point value for this task from 3 to 2.

dr0ptp4kt raised the priority of this task from Medium to High.Jun 6 2016, 4:56 PM

dr0ptp4kt lowered the priority of this task from High to Medium.

dr0ptp4kt edited projects, added Reading-Web-Sprint-75-Quantitative-Paralysis; removed Reading-Web-Sprint-74-Page-views-page-views-PAGE-VIEWS.Jun 6 2016, 5:03 PM

dr0ptp4kt moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 14 2016, 4:52 PM

dr0ptp4kt moved this task from 2016-17 Q2 to 2015-16 Q4 on the Web-Team-Backlog-Archived board.Jun 21 2016, 5:26 PM

phuedx moved this task from To Do to Doing on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 23 2016, 9:46 AM

phuedx claimed this task.Jun 23 2016, 9:55 AM

Change 296199 had a related patch set uploaded (by Phuedx):
Fix main menu rasterized icon regression

https://gerrit.wikimedia.org/r/296199

gerritbot added a project: Patch-For-Review.Jun 27 2016, 10:18 AM

phuedx moved this task from Doing to Code Review on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 27 2016, 10:18 AM

With my change applied:

Screen Shot 2016-06-27 at 11.20.56.png (456×593 px, 56 KB)

When reviewing/QAing my change, please ensure that other browsers that don't support SVG, e.g. IE9, are also positively affected and, as I've changed the canvas size of all of the main menu icons, that there aren't regressions in the Grade A browsers.

LGTM. FF & Chrome on Android, iOS 9.3 iPhone 5s, Opera mini Android.

I don't have IEs or saucelabs account, I'd appreciate if somebody quickly checks before signoff.

Change 296199 merged by jenkins-bot:
Fix main menu rasterized icon regression

https://gerrit.wikimedia.org/r/296199

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-28_(1.28.0-wmf.8)).Jun 27 2016, 12:00 PM

Here are some screenshots:

Windows 7, IE8
Before:

Screen Shot 2016-06-28 at 12.17.11 AM.png (670×786 px, 270 KB)

After:

Screen Shot 2016-06-28 at 12.17.19 AM.png (718×1 px, 375 KB)

Android 6, Opera Mini beta 17.0...
Before:

Screenshot_20160628-002018.png (1×1 px, 67 KB)