Page MenuHomePhabricator
Create Task
Maniphest T136859

Provide a system in VisualEditor-MediaWiki to properly integrate CAPTCHAs
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/02a836977740fc82f18a97f18fd6995f0715cc50/modules/ve-mw/init/ve.init.mw.ArticleTarget.js#L483 is horrible. Let's find a way to make it extensible, and for the code to live predominantly in those extensions.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Move extension save error handlers into a registrymediawiki/extensions/VisualEditormaster+186 -162
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Jun 2 2016, 6:12 PM
Restricted Application added subscribers: Zppix, Florian, Aklapper. · View Herald TranscriptJun 2 2016, 6:12 PM
• AlexMonk-WMF subscribed.Jun 2 2016, 6:26 PM

I have a feeling part of that comment is outdated

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Jun 3 2016, 10:18 PM
Jdforrester-WMF added a parent task: T141676: Move ConfirmEdit-related code out of VisualEditor-MediaWiki and into the ConfirmEdit extension.Jul 30 2016, 12:33 AM
Reedy mentioned this in T157735: Update logging in ConfirmEdit.Feb 16 2017, 9:48 PM
gerritbot subscribed.Nov 23 2018, 5:06 PM

Change 475501 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Move extension save error handlers into a registry

https://gerrit.wikimedia.org/r/475501

gerritbot added a project: Patch-For-Review.Nov 23 2018, 5:06 PM
gerritbot added a comment.Nov 24 2018, 2:41 AM

Change 475501 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Move extension save error handlers into a registry

https://gerrit.wikimedia.org/r/475501

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 24 2018, 3:00 AM
matmarex added a subtask: T211157: Allow VE plugins to handle save errors generated by extensions.Dec 4 2018, 11:05 PM
matmarex closed this task as Resolved.Dec 7 2018, 7:36 PM
matmarex assigned this task to Esanders.
matmarex removed a project: Patch-For-Review.
matmarex subscribed.

(Let's do Editing team QA/product review on T211157, these are all related.)

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 7 2018, 7:36 PM
ppelberg closed subtask T211157: Allow VE plugins to handle save errors generated by extensions as Resolved.Sep 3 2019, 12:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits