Page MenuHomePhabricator

Spike: Plan reforms of the CentralNotice deployment branch
Closed, ResolvedPublic1 Estimated Story PointsSpike

Description

We currently pass make-wmf-branch a "special_extensions" configuration which causes it to cut WMF train release branches from the wmf_deploy branch. This is unlike almost any other extension, and causes lots of confusion both within and without Fundraising Tech. We'd like to be more WMF-standard about how we deploy.

Considerations:

  • We're still fond of keeping control over the master->deployment promotions, so that we can write and CR patches at a normal pace, then deploy only what we intend to.
  • Must be intuitive to deployers outside of fr-tech.

@Catrope suggested one solution which we're leaning towards, but it should be discussed further, hopefully with involvement from the RelEng team. In his scheme, make-wmf-branch would cut wmf.* release branches from whatever is already deployed, and would disregard master or any other branch. In order to deploy new patches, the Fundraising team (usually us) would merge changes from master into the currently active wmf.* branch (for SWAT), or the upcoming wmf.* branch (for going with the train).

Feedback is welcome!

Event Timeline

greg triaged this task as High priority.Jun 14 2016, 6:52 PM
greg raised the priority of this task from High to Needs Triage.
greg subscribed.

(bad drag)

DStrine set the point value for this task to 1.

Following IRL discussion with @thcipriani, it seems there's a pretty easy solution! If the script that automatically generates release branches for extensions can be made to create branches based on wmf_deploy, rather than master, that would allow us to keep fine-grained control over how and when things are deployed, and at the same time let deployments use existing standard procedures. Any thoughts? Thanks in advance!!!!

Change 489906 had a related patch set uploaded (by Thcipriani; owner: Thcipriani):
[mediawiki/tools/release@master] make-wmf-branch: branch special_extensions

https://gerrit.wikimedia.org/r/489906

Change 489906 merged by jenkins-bot:
[mediawiki/tools/release@master] make-wmf-branch: branch special_extensions

https://gerrit.wikimedia.org/r/489906

Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptMay 22 2019, 3:06 PM

This is done, yes?

Pretty sure, yeah! (There are a maybe duplicate-ish and related tasks, we should check 'em out and clean up, sorry for the delay....!)

greg assigned this task to thcipriani.