Page MenuHomePhabricator
Create Task
Maniphest T137055

Article actions width is not 100%
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Article action bar on articles doesn't consume 100% width of the page. it's almost 80% of what it should be and doesn't align on the right side because of it.

Simulator Screen Shot Jun 4, 2016, 5.27.57 PM.png (1×750 px, 418 KB)

Suggested testbed, portrait and landscape, LTR & RTL:

  • Android 2.3 Browser phone form factor
  • Android 4.x/5.x/6.x Chrome phone form factor
  • Android 4.x/5.x/6.x Chrome tablet form factor
  • iOS 9.3 iPhone
  • iOS 9.3 iPad
  • Opera mobile (not mini) Android 4+ phone form factor
  • UC browser (not mini) Android 4+ phone form factor
  • Windows 7.5 Phone IE
  • Desktop Firefox
  • Desktop Chrome
  • Desktop Safari
  • Internet Explorer 11

Note that iOS 8.4 is out of scope while device / testing service available, but iOS 9.3 is pretty close to iOS 8.4 for layout.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Article actions should take up 100% widthmediawiki/extensions/MobileFrontendmaster+5 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Nirzar created this task.Jun 5 2016, 12:32 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 5 2016, 12:32 AM
• Nirzar triaged this task as High priority.Jun 5 2016, 12:32 AM
dr0ptp4kt added a project: MobileFrontend.Jun 6 2016, 4:52 PM
• bmansurov added a comment.Jun 6 2016, 4:52 PM

@Nirzar, do you mean the borders should touch the screen left and right?

• Nirzar added a comment.Jun 6 2016, 4:55 PM

bug.png (1×750 px, 482 KB)

The green should be the padding. and it was. now the width is lesser than that and the red padding is extra.

MBinder_WMF unsubscribed.Jun 6 2016, 8:41 PM
dr0ptp4kt added a parent task: T121919: [GOAL] Improve in-article language switching on mobile web I.Jun 8 2016, 4:17 PM
dr0ptp4kt moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.
• JKatzWMF removed a parent task: T121919: [GOAL] Improve in-article language switching on mobile web I.Jun 15 2016, 11:44 PM
• JKatzWMF added a parent task: T137932: [EPIC] Mobile language switching improvement work II.
dr0ptp4kt added a project: Reading-Web-Sprint-76-Retrosprekfast.Jun 27 2016, 4:06 PM
• bmansurov removed • bmansurov as the assignee of this task.Jun 27 2016, 4:19 PM

I'm currently not working on the task.

dr0ptp4kt set the point value for this task to 2.Jun 27 2016, 4:28 PM
dr0ptp4kt moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-76-Retrosprekfast board.
MBinder_WMF moved this task from Triaged but Future to 2016-17 Q2 on the Web-Team-Backlog-Archived board.Jun 29 2016, 5:17 PM
dr0ptp4kt updated the task description. (Show Details)Jun 29 2016, 6:06 PM
dr0ptp4kt updated the task description. (Show Details)Jun 30 2016, 3:42 PM
• Nirzar added a comment.Jul 1 2016, 6:43 AM

@dr0ptp4kt do we need regression tag on this. i don't want it to be part of UX debt.

• bmansurov added a comment.Jul 1 2016, 7:41 AM

@Nirzar, I don't think so. The feature was implemented wrongly in the first place. My bad.

MBinder_WMF moved this task from 2016-17 Q2 to 2015-16 Q4 on the Web-Team-Backlog-Archived board.Jul 5 2016, 4:42 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 5 2016, 6:40 PM
gerritbot subscribed.Jul 5 2016, 6:45 PM

Change 297455 had a related patch set uploaded (by Jdlrobson):
Article actions should take up 100% width

https://gerrit.wikimedia.org/r/297455

gerritbot added a project: Patch-For-Review.Jul 5 2016, 6:45 PM
Jdlrobson claimed this task.Jul 5 2016, 6:46 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-76-Retrosprekfast board.
• bmansurov moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 6 2016, 10:49 AM
Jdlrobson moved this task from -1 (Needs More Work) to Doing on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 6 2016, 5:33 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 6 2016, 5:38 PM
• bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 7 2016, 2:46 AM
gerritbot added a comment.Jul 7 2016, 2:50 AM

Change 297455 merged by jenkins-bot:
Article actions should take up 100% width

https://gerrit.wikimedia.org/r/297455

• bmansurov closed this task as Resolved.EditedJul 7 2016, 2:52 AM

To test please visit http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Page_actions&mobileaction=beta and look at the language switcher and edit icons to make sure they are properly aligned with the page borders. The screen size needs to be less than the tablet screen size.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)).Jul 7 2016, 3:00 AM
• Nirzar added a comment.Jul 7 2016, 9:44 AM

looks good

MBinder_WMF moved this task from 2015-16 Q4 to 2016-17 Q1 on the Web-Team-Backlog-Archived board.Jul 7 2016, 8:11 PM
• bmansurov removed a project: Patch-For-Review.Jul 12 2016, 5:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits