Page MenuHomePhabricator

After editing redirects on mobile-web, you are linked to the target instead of &redirect=no
Closed, ResolvedPublic

Description

  1. Go to a redirect in Safari, with mobile web (example: https://en.m.wikipedia.org/w/index.php?title=%F0%9F%91%8C&redirect=no)
  2. Edit it in mobile
  3. After pessing save, instead of seeing the "redirect page" with you edits, you are redirected to the target page (i.e. not adding &redirect=no after the edit to the url)

Event Timeline

Cannot replicate this on safari mobile version 11, or any other browser (mobile or desktop).

Can anyone else replicate it or is this no longer an issue?

Cannot replicate this on safari mobile version 11, or any other browser (mobile or desktop).

Can anyone else replicate it or is this no longer an issue?

Seems to have been fixed, at least now that I tested

From what I can tell, the editor now doesnt redirect on a successful save but instead refreshes the current page using window.location.reload(), so I cant see how this would occur anymore.

If this is the case, i think closing the issue and especially removing it from the google code in site would be a good plan

I was planning to claim this on GCI, but thankfully checked here before I did. If no one can reproduce this any longer, I think this should be removed from the GCI site as soon as possible.

Update:

Looking through the version history, it would appear that this was fixed here, as this is where it stopped redirecting to a url based on the page title (which would remove any GET variables) and just reloaded the current page

https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/MobileFrontend/+/53776b8e17b15ffc8aba6ed45442ea9667484b7a

@Jdlrobson: Can you confirm that your patch linked in the last comment already fixed this task? :)

Jdlrobson claimed this task.

I guess i inadvertently did fix this. Thanks for the detective work @Arcayn!

@Aklapper investigating a bug is just as important as writing a patch so i hope students get credited with investigating this as a task completed!!