Page MenuHomePhabricator

[EPIC] Page content should use full page width so users don't have to scroll horizontally
Closed, DeclinedPublic

Assigned To
None
Authored By
Peter
Jun 5 2016, 7:55 PM
Referenced Files
F4133255: barack.gif
Jun 5 2016, 7:55 PM
F4133110: barack-landscape.gif
Jun 5 2016, 7:55 PM
F4133114: bounty.gif
Jun 5 2016, 7:55 PM

Description

We have pages today on mobile that are broader than the viewport or that have elements that are smaller. The long run goal should be to eliminate them all and there's couple things that will help us reach that goal:

  • Emulate mobile view on desktop preview page T85587 to make it easier for users to know what it looks like on mobile
  • Fine tune the CSS to make sure it doesn't happen
  • Use a tool in CI to find these pages. Use the same tool on production to find the pages and fix the problems.

One thing that makes this more complicated is that there are problems that we can find with PhantomJS/Chrome emulating a mobile phone, and some where we need to test on real devices.

Here's a couple of examples of what it looks like today:

Barack Obama landscape mode - some elements full width some half

barack-landscape.gif (1,334×750 px, 3 MB)

Barack Obama portrait mode - some elements are to wide so we can scroll horizontal

barack.gif (750×1,334 px, 8 MB)

Bounty (only Safari iOS) - there's elements that totally makes the width wrong

bounty.gif (750×1,334 px, 9 MB)

A good start would be to find a tool/create a tool that can find these issues and try to get a feeling on how big the problem is.

Event Timeline

MBinder_WMF renamed this task from Use the full width (no more no less) to Page content should use full page width so users don't have to scroll horizontally.Aug 25 2016, 8:13 PM
MBinder_WMF triaged this task as Low priority.
Jdlrobson subscribed.

Emulate mobile view on desktop preview page T85587 to make it easier for users to know what it looks like on mobile

This is captured on T85587

Fine tune the CSS to make sure it doesn't happen

Most of these styles come from editors. When TemplateStyles arrives we'll be able to fix this.

Use a tool in CI to find these pages. Use the same tool on production to find the pages and fix the problems.

@Peter do you mind if I repurpose this task for this specific item? This seems very actionable and useful to help the other 2 problems although I'm not sure exactly what a solution would look like.

I'm not sure what the best way to log this would be.

The best place to do so would be within the edit preview as an edit warning, but I'm not sure how feasible this is in client side code inside Vector.

Can we throw warnings in JavaScript similar to how we do in PHP? Ideally, we'd then be able to identify problems programatically.

Jdlrobson renamed this task from Page content should use full page width so users don't have to scroll horizontally to [EPIC] Page content should use full page width so users don't have to scroll horizontally.Jun 5 2017, 6:07 PM
Jdlrobson added projects: VisualEditor, Epic.

Isn't it better to just close this ? It's so unspecific..