$ python update_database.py -countrycode:cn -lang:enWorking on countrycode "cn" in language "en" Retrieving 26 pages from wikipedia:en.
Unknown error occurred when processing country cn in lang en Un-defined converter in config for monuments_cn_(en): generateRegistrantUrl
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove illegal uses of generateRegistrantUrl | labs/tools/heritage | master | +15 -16 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | JeanFred | T137092 Get Poland back on the monuments database | |||
| Resolved | JeanFred | T137096 Several countries use `generateRegistrantUrl` converter without defining a 'registrantUrlBase' |
This is actually working as expected. Countries should not use generateRegistrantUrl without defining registrantUrlBase
Here are the culprits:
('jo', 'ar')
('gb-wls', 'en')
('az', 'az')
('hu', 'hu')
('be-wal', 'en')
('pk', 'en')
('dz', 'ar')
('pl', 'pl')
('th', 'th')
('sv', 'es')
('np', 'en')
('be-wal', 'nl')
('cn', 'en')
('tn', 'fr')
('be-wal', 'fr')
('es', 'ca')Change 292908 had a related patch set uploaded (by Jean-Frédéric):
[FAILING] Add test ensuring correct usage of generateRegistrantUrl
I’m tempted to just go ahead and remove all illegal usages of generateRegistrantUrl. Thoughts @Lokal_Profil?
Sounds good with me. Can't think of any case where that would be a problem.
Possibly they were added due to T55813? But even so...
Mentioned in SAL [2016-06-06T15:46:30Z] <JeanFred> Deployed latest from Git: b77b7c2 (T137096)
$ tools.heritage@tools-bastion-03:~/heritage/erfgoedbot$ python update_database.py -countrycode:pl -lang:pl Working on countrycode "pl" in language "pl" Retrieving 50 pages from wikipedia:pl. Found unknown field on page Wikipedia:Wiki_Lubi_Zabytki/kujawsko-pomorskie/powiat_grudziądzki/gmina_Gruta : (zespół złożony: tak) Found unknown field on page Wikipedia:Wiki_Lubi_Zabytki/kujawsko-pomorskie/powiat_grudziądzki/gmina_Łasin : (zespół złożony: tak) Retrieving 50 pages from wikipedia:pl.
Looks like everything should be fine now. :)