Page MenuHomePhabricator
Create Task
Maniphest T137126

MessageDialog#fitActions doesn't work on Firefox when some of the actions are hidden
Closed, ResolvedPublic
Actions

Description

As reported by @sladen at T135808, MessageDialog#fitActions always arranges the action buttons vertically on Firefox, even if there is enough space to arrange them horizontally, when some of the actions are hidden (e.g. due to a mode on the ActionSet that disallows them). The hidden actions are incorrectly not being ignored when measuring dimensions and for some reason the action.$element.innerWidth() < action.$label.outerWidth( true ) check passes on Firefox (in Chrome it does not, and this problem doesn't appear).

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.44.0mediawiki/coremaster+2 K -6 K
Use flexbox for MessageDialog horizontal layoutoojs/uimaster+8 -16
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Jun 6 2016, 6:08 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 6 2016, 6:08 PM
matmarex mentioned this in T135808: "Start editing" popup can't be dismissed without clicking "Start editing".Jun 6 2016, 6:32 PM
Esanders mentioned this in T303972: MessageDialog#fitActions arranges buttons horizontally Firefox when they don't fit.Mar 16 2022, 4:08 PM
gerritbot added a comment.Mar 16 2022, 4:59 PM

Change 771382 had a related patch set uploaded (by Esanders; author: Esanders):

[oojs/ui@master] Use flexbox for MessageDialog horizontal layout

https://gerrit.wikimedia.org/r/771382

gerritbot added a project: Patch-For-Review.Mar 16 2022, 4:59 PM
PatchDemoBot added a comment.Mar 16 2022, 5:05 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/e6e4355895/w/

Also created an OOUI Demos page:
https://patchdemo.wmflabs.org/wikis/e6e4355895/w/build/ooui/demos

gerritbot added a comment.Mar 22 2022, 1:24 AM

Change 771382 merged by jenkins-bot:

[oojs/ui@master] Use flexbox for MessageDialog horizontal layout

https://gerrit.wikimedia.org/r/771382

Maintenance_bot removed a project: Patch-For-Review.Mar 22 2022, 2:11 AM
gerritbot added a comment.May 17 2022, 6:02 PM

Change 792684 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Update OOUI to v0.44.0

https://gerrit.wikimedia.org/r/792684

gerritbot added a project: Patch-For-Review.May 17 2022, 6:02 PM
gerritbot added a comment.May 17 2022, 7:07 PM

Change 792684 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.44.0

https://gerrit.wikimedia.org/r/792684

Maintenance_bot removed a project: Patch-For-Review.May 17 2022, 7:30 PM
Volker_E moved this task from Backlog to OOUI-0.44.0 on the OOUI board.May 25 2022, 5:49 AM
Volker_E edited projects, added OOUI (OOUI-0.44.0); removed OOUI.
Volker_E closed this task as Resolved.May 25 2022, 6:06 AM
Volker_E assigned this task to Esanders.
PatchDemoBot added a comment.May 27 2022, 2:24 PM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/e6e4355895/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL