As reported by @sladen at T135808, MessageDialog#fitActions always arranges the action buttons vertically on Firefox, even if there is enough space to arrange them horizontally, when some of the actions are hidden (e.g. due to a mode on the ActionSet that disallows them). The hidden actions are incorrectly not being ignored when measuring dimensions and for some reason the action.$element.innerWidth() < action.$label.outerWidth( true ) check passes on Firefox (in Chrome it does not, and this problem doesn't appear).
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Update OOUI to v0.44.0 | mediawiki/core | master | +2 K -6 K | |
Use flexbox for MessageDialog horizontal layout | oojs/ui | master | +8 -16 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 771382 had a related patch set uploaded (by Esanders; author: Esanders):
[oojs/ui@master] Use flexbox for MessageDialog horizontal layout
Comment Actions
Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/e6e4355895/w/
Also created an OOUI Demos page:
https://patchdemo.wmflabs.org/wikis/e6e4355895/w/build/ooui/demos
Comment Actions
Change 771382 merged by jenkins-bot:
[oojs/ui@master] Use flexbox for MessageDialog horizontal layout
Comment Actions
Change 792684 had a related patch set uploaded (by Jforrester; author: Jforrester):
[mediawiki/core@master] Update OOUI to v0.44.0
Comment Actions
Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted: