Refactor: Sort out transaction_option vs getData* vs getTransactionSpecificValue vs account* constellation
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	awight
	Jun 6 2016, 10:56 PM

Description

Come up with a more intuitive interface to our different forms of data. With only a few obvious exceptions, almost all code should be using getNormalized to access data.

getNormalized: Get data using a normalized key, in its normalized form.
Staged data should be built just in time, I don't believe we ever need to store it. This might require some adjustment to legacy staging functions (Adyen).
(T130154) Looking at it more, I really don't like how accountInfo works. Get rid of the defineAccountInfo functions, use account_config everywhere. Don't use magic to stuff account config into transaction values.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	AstroPay signature as staging helper	mediawiki/extensions/DonationInterface	master	+53 -39
	EncodingMangler implements StagingHelper	mediawiki/extensions/DonationInterface	master	+23 -22

Customize query in gerrit

Related Objects

Mentioned Here: T130154: account_config vs accountInfo vs account_name is a mess

Event Timeline

awight created this task.Jun 6 2016, 10:56 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 6 2016, 10:56 PM

Also see T130154

awight renamed this task from Refactor: Sort out transaction_option vs getData* vs getTransactionSpecificValue vs accountInfo vs account_config to Refactor: Sort out transaction_option vs getData* vs getTransactionSpecificValue vs account* constellation.Jun 7 2016, 9:11 PM

awight updated the task description. (Show Details)

Change 293465 had a related patch set uploaded (by Ejegg):
AstroPay signature as staging helper

https://gerrit.wikimedia.org/r/293465

gerritbot added a project: Patch-For-Review.Jun 9 2016, 4:11 AM

Also, how about the staged data keys are the processor names, not ours. We could have one generic staging/unstaging helper 'KeyMapper' that just copies over values, altering keys as defined in var_map (see TODO on $theirKey => $ourKey thing in GlobalCollect). Its stage function could be transaction-aware and only copy over what's needed for the current txn.

Another generic staging helper could copy over the 'values' section of the current transaction, and a third could copy the appropriate account config.

Then $staged_data would just need to be encoded in the right format to send to the processor, and we could dispense with getTransactionSpecificValue entirely.

Change 293466 had a related patch set uploaded (by Ejegg):
EncodingMangler implements StagingHelper

https://gerrit.wikimedia.org/r/293466

Change 293466 merged by jenkins-bot:
EncodingMangler implements StagingHelper

https://gerrit.wikimedia.org/r/293466

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-19_(1.28.0-wmf.11)).Jul 13 2016, 10:00 PM

Change 293465 merged by jenkins-bot:
AstroPay signature as staging helper

https://gerrit.wikimedia.org/r/293465

• DStrine moved this task from Triage to FY 2022-2023 on the Fundraising-Backlog board.Jul 19 2016, 8:35 PM

• mmodell removed a subscriber: awight.Jun 22 2017, 9:38 PM

• DStrine moved this task from FY 2022-2023 to Adam's old tasks on the Fundraising-Backlog board.May 6 2019, 8:48 PM

Umherirrender closed this task as Resolved.Apr 5 2022, 7:46 PM

Umherirrender removed a project: Patch-For-Review.