Description

Compare https://en.wikipedia.org/wiki/Special:Nearby#/page/Empire_State_Building
to https://en.wikipedia.org/wiki/Special:Nearby#/coord/40.748433,-73.985656

When searching by coordinate the sort order is correct, but when searching by page the sorting is lost. It looks like searching by geocordinate is re-sorting after retrieving the pages from api, while by page is not. Because the api is being used as a generator the returned sort order is completely arbitrary.

Remaining work

Sort by index given by GeoData (thanks @MaxSem!) in Nearby special page

Details

	Subject	Repo	Branch	Lines +/-
	Add index to results in generator mode	mediawiki/extensions/GeoData	master	+5 -0

Customize query in gerrit

Event Timeline

EBernhardson created this task.Jun 6 2016, 11:42 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 6 2016, 11:42 PM

Normal search deals with that here: https://github.com/wikimedia/mediawiki/blob/master/includes/api/ApiQuerySearch.php#L297-L299

Which allows the frontend to see the original sort order and re-sort the generator output. api maintainers identified too many edge cases to do that resort on the generator output

EBernhardson added subscribers: aude, MaxSem.Jun 6 2016, 11:58 PM

Danny_B added a project: MediaWiki-Special-pages.Jun 7 2016, 10:02 AM

EBernhardson updated the task description. (Show Details)Jun 7 2016, 2:57 PM

Sethakill moved this task from To triage to Extension-related special pages on the MediaWiki-Special-pages board.Jun 7 2016, 4:29 PM

phuedx added a project: Web-Team-Backlog.Jun 7 2016, 5:08 PM

• jhobs triaged this task as Medium priority.Jun 7 2016, 5:12 PM

• jhobs moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

MaxSem claimed this task.Jun 7 2016, 9:09 PM

Change 293244 had a related patch set uploaded (by MaxSem):
Add index to results in generator mode

https://gerrit.wikimedia.org/r/293244

gerritbot added a project: Patch-For-Review.Jun 7 2016, 11:54 PM

Change 293244 merged by jenkins-bot:
Add index to results in generator mode